Bug 1200063 - Rename MakeAPZCInstance to NewAPZCInstance for consistency. r=kats
authorBotond Ballo <botond@mozilla.com>
Wed, 16 Sep 2015 19:10:24 -0400
changeset 295578 92bf6f7917f37712e0055ec78d820022e090807c
parent 295577 4a6a55be667635645c26809469bd88ac2e643bf5
child 295579 c05e13ac8ce00b2b6b4c9e2baf27cc5f403b15b9
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats
bugs1200063
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1200063 - Rename MakeAPZCInstance to NewAPZCInstance for consistency. r=kats
gfx/layers/apz/src/APZCTreeManager.cpp
gfx/layers/apz/src/APZCTreeManager.h
gfx/tests/gtest/TestAsyncPanZoomController.cpp
--- a/gfx/layers/apz/src/APZCTreeManager.cpp
+++ b/gfx/layers/apz/src/APZCTreeManager.cpp
@@ -103,19 +103,19 @@ APZCTreeManager::APZCTreeManager()
   mApzcTreeLog.ConditionOnPrefFunction(gfxPrefs::APZPrintTree);
 }
 
 APZCTreeManager::~APZCTreeManager()
 {
 }
 
 AsyncPanZoomController*
-APZCTreeManager::MakeAPZCInstance(uint64_t aLayersId,
-                                  GeckoContentController* aController,
-                                  TaskThrottler* aPaintThrottler)
+APZCTreeManager::NewAPZCInstance(uint64_t aLayersId,
+                                 GeckoContentController* aController,
+                                 TaskThrottler* aPaintThrottler)
 {
   return new AsyncPanZoomController(aLayersId, this, mInputQueue,
     aController, aPaintThrottler, AsyncPanZoomController::USE_GESTURE_DETECTOR);
 }
 
 TimeStamp
 APZCTreeManager::GetFrameTime()
 {
@@ -425,18 +425,18 @@ APZCTreeManager::PrepareNodeForLayer(con
       // this is the first APZC for this layers id.
       auto throttlerInsertResult = mPaintThrottlerMap.insert(
           std::make_pair(aLayersId, nsRefPtr<TaskThrottler>()));
       if (throttlerInsertResult.second) {
         throttlerInsertResult.first->second = new TaskThrottler(
             GetFrameTime(), TimeDuration::FromMilliseconds(500));
       }
 
-      apzc = MakeAPZCInstance(aLayersId, state->mController,
-                              throttlerInsertResult.first->second);
+      apzc = NewAPZCInstance(aLayersId, state->mController,
+                             throttlerInsertResult.first->second);
       apzc->SetCompositorParent(aState.mCompositor);
       if (state->mCrossProcessParent != nullptr) {
         apzc->ShareFrameMetricsAcrossProcesses();
       }
       MOZ_ASSERT(node == nullptr);
       node = new HitTestingTreeNode(apzc, true, aLayersId);
     } else {
       // If we are re-using a node for this layer clear the tree pointers
--- a/gfx/layers/apz/src/APZCTreeManager.h
+++ b/gfx/layers/apz/src/APZCTreeManager.h
@@ -388,19 +388,19 @@ public:
    */
   nsRefPtr<const OverscrollHandoffChain> BuildOverscrollHandoffChain(const nsRefPtr<AsyncPanZoomController>& aInitialTarget);
 
 protected:
   // Protected destructor, to discourage deletion outside of Release():
   virtual ~APZCTreeManager();
 
   // Protected hooks for gtests subclass
-  virtual AsyncPanZoomController* MakeAPZCInstance(uint64_t aLayersId,
-                                                   GeckoContentController* aController,
-                                                   TaskThrottler* aPaintThrottler);
+  virtual AsyncPanZoomController* NewAPZCInstance(uint64_t aLayersId,
+                                                  GeckoContentController* aController,
+                                                  TaskThrottler* aPaintThrottler);
 public:
   // Public hooks for gtests subclass
   virtual TimeStamp GetFrameTime();
 
 public:
   /* Some helper functions to find an APZC given some identifying input. These functions
      lock the tree of APZCs while they find the right one, and then return an addref'd
      pointer to it. This allows caller code to just use the target APZC without worrying
--- a/gfx/tests/gtest/TestAsyncPanZoomController.cpp
+++ b/gfx/tests/gtest/TestAsyncPanZoomController.cpp
@@ -149,19 +149,19 @@ class TestAPZCTreeManager : public APZCT
 public:
   explicit TestAPZCTreeManager(MockContentControllerDelayed* aMcc) : mcc(aMcc) {}
 
   nsRefPtr<InputQueue> GetInputQueue() const {
     return mInputQueue;
   }
 
 protected:
-  AsyncPanZoomController* MakeAPZCInstance(uint64_t aLayersId,
-                                           GeckoContentController* aController,
-                                           TaskThrottler* aPaintThrottler) override;
+  AsyncPanZoomController* NewAPZCInstance(uint64_t aLayersId,
+                                          GeckoContentController* aController,
+                                          TaskThrottler* aPaintThrottler) override;
 
   TimeStamp GetFrameTime() override {
     return mcc->Time();
   }
 
 private:
   nsRefPtr<MockContentControllerDelayed> mcc;
 };
@@ -256,19 +256,19 @@ public:
   }
 
 private:
   bool mWaitForMainThread;
   MockContentControllerDelayed* mcc;
 };
 
 AsyncPanZoomController*
-TestAPZCTreeManager::MakeAPZCInstance(uint64_t aLayersId,
-                                      GeckoContentController* aController,
-                                      TaskThrottler* aPaintThrottler)
+TestAPZCTreeManager::NewAPZCInstance(uint64_t aLayersId,
+                                     GeckoContentController* aController,
+                                     TaskThrottler* aPaintThrottler)
 {
   MockContentControllerDelayed* mcc = static_cast<MockContentControllerDelayed*>(aController);
   return new TestAsyncPanZoomController(aLayersId, mcc, this, aPaintThrottler,
       AsyncPanZoomController::USE_GESTURE_DETECTOR);
 }
 
 static FrameMetrics
 TestFrameMetrics()