Bug 1330225. Remove unused function nsViewManager::InsertChild. r=mats
authorTimothy Nikkel <tnikkel@gmail.com>
Thu, 12 Jan 2017 00:59:11 -0600
changeset 374132 8f927b0973bc2c90fdb65ea4574fff24525484db
parent 374131 3c7c8b14e0bb86eae9339bfb2ca602b00e83abee
child 374133 4a1f0be6fa1d318be2799b5066a098a9c931fa70
push id6996
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 20:48:21 +0000
treeherdermozilla-beta@d89512dab048 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats
bugs1330225
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1330225. Remove unused function nsViewManager::InsertChild. r=mats
view/nsViewManager.cpp
view/nsViewManager.h
--- a/view/nsViewManager.cpp
+++ b/view/nsViewManager.cpp
@@ -932,25 +932,16 @@ nsViewManager::InsertChild(nsView *aPare
 
       // if the parent view is marked as "floating", make the newly added view float as well.
       if (aParent->GetFloating())
         aChild->SetFloating(true);
     }
 }
 
 void
-nsViewManager::InsertChild(nsView *aParent, nsView *aChild, int32_t aZIndex)
-{
-  // no-one really calls this with anything other than aZIndex == 0 on a fresh view
-  // XXX this method should simply be eliminated and its callers redirected to the real method
-  SetViewZIndex(aChild, false, aZIndex);
-  InsertChild(aParent, aChild, nullptr, true);
-}
-
-void
 nsViewManager::RemoveChild(nsView *aChild)
 {
   NS_ASSERTION(aChild, "aChild must not be null");
 
   nsView* parent = aChild->GetParent();
 
   if (nullptr != parent) {
     NS_ASSERTION(aChild->GetViewManager() == this ||
--- a/view/nsViewManager.h
+++ b/view/nsViewManager.h
@@ -143,18 +143,16 @@ public:
    * @param aParent parent view
    * @param aChild child view
    * @param aSibling sibling view
    * @param aAfter after or before in the document order
    */
   void InsertChild(nsView *aParent, nsView *aChild, nsView *aSibling,
                    bool aAfter);
 
-  void InsertChild(nsView *aParent, nsView *aChild, int32_t aZIndex);
-
   /**
    * Remove a specific child view from its parent. This will NOT remove its placeholder
    * if there is one.
    * The view manager generates the appropriate dirty regions.
    * @param aParent parent view
    * @param aChild child view
    */
   void RemoveChild(nsView *aChild);