Bug 1481951 late-breaking followup: Remove mistaken comment with a reference to this (closed) bug. r=TYLin
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 30 Aug 2019 20:37:10 +0000
changeset 551451 8f159b8c631d3e2d05a81644ad435ca751a8aefe
parent 551450 935f01089bf510d412935935e93a237843f14d77
child 551452 4d4271a0ccad1e5a561ca93bd4144767cf0503a4
push id11865
push userbtara@mozilla.com
push dateMon, 02 Sep 2019 08:54:37 +0000
treeherdermozilla-beta@37f59c4671b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersTYLin
bugs1481951
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1481951 late-breaking followup: Remove mistaken comment with a reference to this (closed) bug. r=TYLin DONTBUILD because this is a comment-only change. Per bug 1481951 comment 6, it seems our behavior was in fact correct even when the comment was added, and this "// XXX" comment was just due to a misunderstanding in what was going on in the testcase. Differential Revision: https://phabricator.services.mozilla.com/D44229
layout/generic/nsFrame.cpp
--- a/layout/generic/nsFrame.cpp
+++ b/layout/generic/nsFrame.cpp
@@ -9706,17 +9706,16 @@ void nsFrame::ConsiderChildOverflow(nsOv
   if (StyleDisplay()->IsContainLayout() &&
       IsFrameOfType(eSupportsContainLayoutAndPaint)) {
     // If we have layout containment and are not a non-atomic, inline-level
     // principal box, we should only consider our child's visual (ink) overflow,
     // leaving the scrollable regions of the parent unaffected.
     // Note: scrollable overflow is a subset of visual overflow,
     // so this has the same affect as unioning the child's visual and
     // scrollable overflow with the parent's visual overflow.
-    // XXX doesn't work correctly for floats - bug 1481951
     nsRect childVisual = aChildFrame->GetVisualOverflowRect();
     nsOverflowAreas combined = nsOverflowAreas(childVisual, nsRect());
     aOverflowAreas.UnionWith(combined + aChildFrame->GetPosition());
   } else {
     aOverflowAreas.UnionWith(aChildFrame->GetOverflowAreas() +
                              aChildFrame->GetPosition());
   }
 }