Mark AsyncWaiter as final, no bug, blanket-r=bzbarsky
authorEhsan Akhgari <ehsan@mozilla.com>
Fri, 05 Oct 2012 10:48:49 -0400
changeset 115690 8e432edff70b23c126c43f127755550f394f52d7
parent 115689 a31b3a3b7954f09b5b8f680c84c2d55a657086bb
child 115691 fba8214bfe19ad4c203ca3d684a5bbec5e6eb834
push id1708
push userakeybl@mozilla.com
push dateMon, 19 Nov 2012 21:10:21 +0000
treeherdermozilla-beta@27b14fe50103 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone18.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Mark AsyncWaiter as final, no bug, blanket-r=bzbarsky
ipc/chromium/src/base/waitable_event_watcher_posix.cc
--- a/ipc/chromium/src/base/waitable_event_watcher_posix.cc
+++ b/ipc/chromium/src/base/waitable_event_watcher_posix.cc
@@ -4,16 +4,18 @@
 
 #include "base/waitable_event_watcher.h"
 
 #include "base/condition_variable.h"
 #include "base/lock.h"
 #include "base/message_loop.h"
 #include "base/waitable_event.h"
 
+#include "mozilla/Attributes.h"
+
 namespace base {
 
 // -----------------------------------------------------------------------------
 // WaitableEventWatcher (async waits).
 //
 // The basic design is that we add an AsyncWaiter to the wait-list of the event.
 // That AsyncWaiter has a pointer to MessageLoop, and a Task to be posted to it.
 // The MessageLoop ends up running the task, which calls the delegate.
@@ -45,17 +47,17 @@ class Flag : public RefCountedThreadSafe
   mutable Lock lock_;
   bool flag_;
 };
 
 // -----------------------------------------------------------------------------
 // This is an asynchronous waiter which posts a task to a MessageLoop when
 // fired. An AsyncWaiter may only be in a single wait-list.
 // -----------------------------------------------------------------------------
-class AsyncWaiter : public WaitableEvent::Waiter {
+class AsyncWaiter MOZ_FINAL : public WaitableEvent::Waiter {
  public:
   AsyncWaiter(MessageLoop* message_loop, Task* task, Flag* flag)
       : message_loop_(message_loop),
         cb_task_(task),
         flag_(flag) { }
 
   bool Fire(WaitableEvent* event) {
     if (flag_->value()) {