Bug 1504529 [wpt PR 13908] - Fix regressions introduced in https://github.com/web-platform-tests/wpt/pull/13893, a=testonly
authoryouennf <youennf@users.noreply.github.com>
Tue, 13 Nov 2018 11:51:43 +0000
changeset 502690 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
parent 502689 cbe253cf41f5e6c94312d6cd5b04f1099c5fb799
child 502691 516605726fa97808c92e98c531843a399a8a2be6
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1504529, 13908, 13893
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1504529 [wpt PR 13908] - Fix regressions introduced in https://github.com/web-platform-tests/wpt/pull/13893, a=testonly Automatic update from web-platform-testsFix regressions introduced in https://github.com/web-platform-tests/wpt/pull/13893 (#13908) -- wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564 wpt-pr: 13908
testing/web-platform/tests/webrtc/RTCPeerConnection-helper.js
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-helper.js
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-helper.js
@@ -100,18 +100,18 @@ function assert_session_desc_similar(ses
 
 function assert_session_desc_not_similar(sessionDesc1, sessionDesc2) {
   assert_false(isSimilarSessionDescription(sessionDesc1, sessionDesc2),
     'Expect both session descriptions to have different count of media lines');
 }
 
 async function generateDataChannelOffer(pc) {
   pc.createDataChannel('test');
-  const offer = pc.createOffer();
-  assert_equals(countApplicationLine(sdp), 1, 'Expect m=application line to be present in generated SDP');
+  const offer = await pc.createOffer();
+  assert_equals(countApplicationLine(offer.sdp), 1, 'Expect m=application line to be present in generated SDP');
   return offer;
 }
 
 async function generateAudioReceiveOnlyOffer(pc)
 {
     try {
         pc.addTransceiver('audio', { direction: 'recvonly' });
         return pc.createOffer();
@@ -130,17 +130,17 @@ async function generateVideoReceiveOnlyO
     }
 }
 
 // Helper function to generate answer based on given offer using a freshly
 // created RTCPeerConnection object
 async function generateAnswer(offer) {
   const pc = new RTCPeerConnection();
   await pc.setRemoteDescription(offer);
-  const answer = pc.createAnswer();
+  const answer = await pc.createAnswer();
   pc.close();
   return answer;
 }
 
 // Run a test function that return a promise that should
 // never be resolved. For lack of better options,
 // we wait for a time out and pass the test if the
 // promise doesn't resolve within that time.