Bug 1534935: Fix non-nsView ShouldNotBeVisible(). r=jmathies
authorAdam Gashlin <agashlin@mozilla.com>
Fri, 15 Mar 2019 21:21:05 +0000
changeset 522349 8db388171af6d6d1f9737923f988df27f67bdb33
parent 522348 08d9090316cf9942ce7749159079622418adf671
child 522350 aab6db0102cf6d755b1fd256dfb43f4d8579e985
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmathies
bugs1534935
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534935: Fix non-nsView ShouldNotBeVisible(). r=jmathies The comment was correct, the base impl should always return false as we don't have an opinion about visibility. Differential Revision: https://phabricator.services.mozilla.com/D23598
widget/nsIWidgetListener.cpp
--- a/widget/nsIWidgetListener.cpp
+++ b/widget/nsIWidgetListener.cpp
@@ -67,15 +67,15 @@ void nsIWidgetListener::DidPaintWindow()
 void nsIWidgetListener::DidCompositeWindow(
     mozilla::layers::TransactionId aTransactionId,
     const TimeStamp& aCompositeStart, const TimeStamp& aCompositeEnd) {}
 
 void nsIWidgetListener::RequestRepaint() {}
 
 bool nsIWidgetListener::ShouldNotBeVisible() {
   // Returns false to assume that nothing should happen in most cases.
-  return true;
+  return false;
 }
 
 nsEventStatus nsIWidgetListener::HandleEvent(WidgetGUIEvent* aEvent,
                                              bool aUseAttachedEvents) {
   return nsEventStatus_eIgnore;
 }