Bug 1552052 - Do not dump mochitest/reftest logcat for successful runs; r=bc
authorGeoff Brown <gbrown@mozilla.com>
Wed, 15 May 2019 22:48:26 +0000
changeset 532834 8c8d7435dad6a4728cedb6ac714b88d981ed6b6c
parent 532833 cebebf6790ab1d5dc82dafb329843f02931ab819
child 532835 aff4e1440f1a58fb3c8f497e2558c950236a2b82
push id11272
push userapavel@mozilla.com
push dateThu, 16 May 2019 15:28:22 +0000
treeherdermozilla-beta@2265bfc5920d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbc
bugs1552052
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552052 - Do not dump mochitest/reftest logcat for successful runs; r=bc Logcat is available as a separate artifact anyway. This makes the test log for successful runs much smaller: easier to read, cheaper to store. Differential Revision: https://phabricator.services.mozilla.com/D31357
layout/tools/reftest/remotereftest.py
testing/mochitest/runtestsremote.py
--- a/layout/tools/reftest/remotereftest.py
+++ b/layout/tools/reftest/remotereftest.py
@@ -427,17 +427,17 @@ def run_test_harness(parser, options):
     except Exception:
         print "Automation Error: Exception caught while running tests"
         traceback.print_exc()
         retVal = 1
 
     reftest.stopWebServer(options)
 
     if options.printDeviceInfo and not options.verify:
-        reftest.printDeviceInfo(printLogcat=True)
+        reftest.printDeviceInfo(printLogcat=(retVal != 0))
 
     return retVal
 
 
 if __name__ == "__main__":
     parser = reftestcommandline.RemoteArgumentsParser()
     options = parser.parse_args()
     sys.exit(run_test_harness(parser, options))
--- a/testing/mochitest/runtestsremote.py
+++ b/testing/mochitest/runtestsremote.py
@@ -377,17 +377,17 @@ def run_test_harness(parser, options):
             try:
                 mochitest.cleanup(options)
             except Exception:
                 # device error cleaning up... oh well!
                 traceback.print_exc()
         retVal = 1
 
     if not device_exception and options.log_mach is None and not options.verify:
-        mochitest.printDeviceInfo(printLogcat=True)
+        mochitest.printDeviceInfo(printLogcat=(retVal != 0))
 
     mochitest.archiveMozLogs()
     mochitest.message_logger.finish()
 
     return retVal
 
 
 def main(args=sys.argv[1:]):