servo: Merge #18457 - Invalidation should check all restyle hints (from legnaleurc:fix_smil); r=emilio
authorWei-Cheng Pan <wpan@mozilla.com>
Tue, 12 Sep 2017 10:58:26 -0500
changeset 429882 8b92071fd024996b05864c077b1fbd7c7c806805
parent 429881 578381b9e794825ff32dce7b4e8a9db82631038f
child 429883 1379a04912daa5d919b785333c265406051a1dc8
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #18457 - Invalidation should check all restyle hints (from legnaleurc:fix_smil); r=emilio For some cases simply check EffectCompositor is not enough, we need to check the dirty bits for animation too. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 9d0f8b9d52a0eb24e971b796e1c4387bd9fe142f
servo/ports/geckolib/glue.rs
--- a/servo/ports/geckolib/glue.rs
+++ b/servo/ports/geckolib/glue.rs
@@ -3854,16 +3854,16 @@ pub extern "C" fn Servo_ProcessInvalidat
     }
 }
 
 #[no_mangle]
 pub extern "C" fn Servo_HasPendingRestyleAncestor(element: RawGeckoElementBorrowed) -> bool {
     let mut element = Some(GeckoElement(element));
     while let Some(e) = element {
         if let Some(data) = e.borrow_data() {
-            if data.restyle.hint.has_non_animation_invalidations() {
+            if !data.restyle.hint.is_empty() {
                 return true;
             }
         }
         element = e.traversal_parent();
     }
     false
 }