mozilla-beta: changeset 553745:8b5aa1f7d1f35feed967c5d0a962bbee95dbf241

☠☠ backed out by 0867c7e61ee2 ☠ ☠
author	Mike Hommey <mh+mozilla@glandium.org>
	Sat, 07 Sep 2019 22:45:47 +0000
changeset 553745	8b5aa1f7d1f35feed967c5d0a962bbee95dbf241
parent 553744	5c432260aacb518cb665d3e5bff0205d3acc1386
child 553746	bdbfce5477b817b6267eb8dd74f0bd2d2899c9b0
push id	12169
push user	ffxbld-merge
push date	Mon, 14 Oct 2019 16:59:29 +0000
treeherder	mozilla-beta@c819687300ed [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	nalexander
bugs	1579156, 1573566
milestone	71.0a1
first release with	nightly linux32 f321dd9af076 / 71.0a1 / 20190910095613 / files nightly linux64 f321dd9af076 / 71.0a1 / 20190910095613 / files nightly mac f321dd9af076 / 71.0a1 / 20190910095613 / files nightly win32 f321dd9af076 / 71.0a1 / 20190910095613 / files nightly win64 f321dd9af076 / 71.0a1 / 20190910095613 / files
last release without	nightly linux32 bdb64cf16b68 / 71.0a1 / 20190909214621 / files nightly linux64 bdb64cf16b68 / 71.0a1 / 20190909214621 / files nightly mac bdb64cf16b68 / 71.0a1 / 20190909214621 / files nightly win32 bdb64cf16b68 / 71.0a1 / 20190909214621 / files nightly win64 bdb64cf16b68 / 71.0a1 / 20190909214621 / files

Bug 1579156 - Fix binding tests after bug 1573566. r=nalexander The build system has no clue that there is something to build in dom/bindings/test. It's currently all handled via make rules generated by the backend, but ideally, this would all be handled by the frontend emitting appropriate GeneratedFiles and Sources objects. In the meanwhile, we just force the make backend to recurse through dom/bindings/test. Differential Revision: https://phabricator.services.mozilla.com/D45124

python/mozbuild/mozbuild/backend/recursivemake.py

file | annotate | diff | comparison | revisions

--- a/python/mozbuild/mozbuild/backend/recursivemake.py
+++ b/python/mozbuild/mozbuild/backend/recursivemake.py
@@ -1822,8 +1822,13 @@ class RecursiveMakeBackend(CommonBackend
 
         self._add_unified_build_rules(mk,
                                       unified_source_mapping,
                                       unified_files_makefile_variable='unified_binding_cpp_files')
 
         webidls_mk = mozpath.join(bindings_dir, 'webidlsrcs.mk')
         with self._write_file(webidls_mk) as fh:
             mk.dump(fh, removal_guard=False)
+
+        # Add the test directory to the compile graph.
+        self._compile_graph[mozpath.join(
+            mozpath.relpath(bindings_dir, self.environment.topobjdir),
+            'test', 'target-objects')]