Backed out changeset f1abdc201968 (bug 823787) for breaking PGO builds on Windows
authorWes Kocher <wkocher@mozilla.com>
Thu, 12 Dec 2013 19:43:25 -0800
changeset 176305 8b5875dc7e316c36f8ff1fb4a0d89bd75681e8b0
parent 176304 1bc33fa19b24d8076b9a09511fcced1f20747757
child 176308 90a364f1f606c084594519eb4d5a70e457c01da2
child 176358 53ca707d8e7aeafeab5a8d41f2ba37f6794293cf
child 176385 168274f77bad31467e7d2cea71f410e8bd38beee
push id3343
push userffxbld
push dateMon, 17 Mar 2014 21:55:32 +0000
treeherdermozilla-beta@2f7d3415f79f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs823787
milestone29.0a1
backs outf1abdc201968ca8ff8c871674e9314a2466b8404
first release with
nightly linux32
8b5875dc7e31 / 29.0a1 / 20131213030203 / files
nightly linux64
8b5875dc7e31 / 29.0a1 / 20131213030203 / files
nightly mac
8b5875dc7e31 / 29.0a1 / 20131213030203 / files
nightly win32
8b5875dc7e31 / 29.0a1 / 20131213030203 / files
nightly win64
8b5875dc7e31 / 29.0a1 / 20131213030203 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset f1abdc201968 (bug 823787) for breaking PGO builds on Windows
build/pgo/profileserver.py
--- a/build/pgo/profileserver.py
+++ b/build/pgo/profileserver.py
@@ -60,20 +60,12 @@ if __name__ == '__main__':
       print "jarlog: %s" % env["MOZ_JAR_LOG_FILE"]
 
     cmdargs = ["http://localhost:%d/index.html" % PORT]
     runner = FirefoxRunner(profile=profile,
                            binary=build.get_binary_path(where="staged-package"),
                            cmdargs=cmdargs,
                            env=env)
     runner.start(debug_args=debug_args, interactive=interactive)
-    status = runner.wait()
+    runner.wait()
     httpd.stop()
-    if status != 0:
-        status = 1      # normalize status, in case it's larger than 127
-
-    # Note:  the |finally| block below will always run.
-    # http://docs.python.org/2/library/sys.html#sys.exit says that sys.exit "is
-    # implemented by raising the SystemExit exception, so cleanup actions
-    # specified by finally clauses of try statements are honored".
-    sys.exit(status)
   finally:
     shutil.rmtree(profilePath)