Bug 1496708 - Install cbindgen as system package. f=gaston, r=froydnj, a=NPOTB
authorJan Beich <jbeich@FreeBSD.org>
Fri, 05 Oct 2018 05:37:00 +0300
changeset 490245 8a68e674c26549c04b3bfefc2939c77a73b88308
parent 490244 a3246a951d2edb5a0bca13be3fd407980361a551
child 490246 27fc86657940c0806d665ca7f6c82fbb9df910cc
push id9960
push userryanvm@gmail.com
push dateTue, 09 Oct 2018 18:58:41 +0000
treeherdermozilla-beta@c05cd826f781 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj, NPOTB
bugs1496708
milestone63.0
Bug 1496708 - Install cbindgen as system package. f=gaston, r=froydnj, a=NPOTB cargo build is no longer called, so bootstrap will be faster. All dependencies (including cbindgen) are usually up-to-date on BSDs because there's no fallback to Mozilla binaries.
python/mozboot/mozboot/freebsd.py
python/mozboot/mozboot/openbsd.py
--- a/python/mozboot/mozboot/freebsd.py
+++ b/python/mozboot/mozboot/freebsd.py
@@ -63,12 +63,12 @@ class FreeBSDBootstrapper(BaseBootstrapp
         self.ensure_browser_packages(artifact_mode=True)
 
     def ensure_browser_packages(self, artifact_mode=False):
         # TODO: Figure out what not to install for artifact mode
         self.pkg_install(*self.browser_packages)
 
     def ensure_stylo_packages(self, state_dir, checkout_root):
         # Clang / llvm already installed as browser package
-        self.ensure_rust_package('cbindgen')
+        self.pkg_install('rust-cbindgen')
 
     def upgrade_mercurial(self, current):
         self.pkg_install('mercurial')
--- a/python/mozboot/mozboot/openbsd.py
+++ b/python/mozboot/mozboot/openbsd.py
@@ -44,9 +44,9 @@ class OpenBSDBootstrapper(BaseBootstrapp
 
     def ensure_browser_packages(self, artifact_mode=False):
         # TODO: Figure out what not to install for artifact mode
         # we use -z because there's no other way to say "any autoconf-2.13"
         self.run_as_root(['pkg_add', '-z'] + self.browser_packages)
 
     def ensure_stylo_packages(self, state_dir, checkout_root):
         # Clang / llvm already installed as browser package
-        self.ensure_rust_package('cbindgen')
+        self.run_as_root(['pkg_add', 'cbindgen'])