Bug 1488972 - Adjust horizontal spacing for the dropdown menu buttons. r=Honza
authorGabriel Luong <gabriel.luong@gmail.com>
Thu, 22 Nov 2018 12:00:23 -0500
changeset 504174 8a54a4fa7f4c2b275208c760d7e93b00b7c78161
parent 504173 f668df79d93b379add8c1019792e6fdef687506b
child 504175 9c4a8d0ce2b49498554bbe04ee5a1e5d52abd5cf
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1488972
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1488972 - Adjust horizontal spacing for the dropdown menu buttons. r=Honza
devtools/client/responsive.html/index.css
devtools/client/themes/toolbars.css
--- a/devtools/client/responsive.html/index.css
+++ b/devtools/client/responsive.html/index.css
@@ -147,35 +147,17 @@ body,
 }
 
 #screenshot-button:disabled {
   filter: var(--theme-icon-checked-filter);
   opacity: 1 !important;
 }
 
 #device-selector {
-  align-self: center;
-  background-position: right 4px center;
   margin-inline-start: 4px;
-  padding-left: 0;
-  width: 8em;
-}
-
-#device-selector .title {
-  width: 85%;
-}
-
-#device-pixel-ratio-menu {
-  width: 6em;
-  /* `max-width` is here to keep the UI compact if the device pixel ratio changes to a
-     repeating decimal value.  This can happen if you zoom the UI (Cmd + Plus / Minus on
-     macOS for example). */
-  max-width: 8em;
-  background-position: right 4px center;
-  padding-left: 0;
 }
 
 #viewports-container {
   display: flex;
   overflow: auto;
   height: 100%;
   width: 100%;
 }
--- a/devtools/client/themes/toolbars.css
+++ b/devtools/client/themes/toolbars.css
@@ -209,18 +209,21 @@
 splitter.devtools-horizontal-splitter,
 .devtools-side-splitter {
   background-color: var(--theme-splitter-color);
 }
 
 /* Dropdown Menu Button */
 .devtools-dropdown-button {
   background-image: url("chrome://devtools/skin/images/select-arrow.svg") !important;
+  background-position: right center !important;
   background-repeat: no-repeat !important;
   overflow: hidden;
+  padding-inline-start: 2px !important;
+  padding-inline-end: 10px !important;
   fill: var(--theme-toolbar-photon-icon-color);
   -moz-context-properties: fill;
 }
 
 .devtools-dropdown-button:not(:hover) {
   background-color: transparent;
 }
 
@@ -228,20 +231,8 @@ splitter.devtools-horizontal-splitter,
 .devtools-dropdown-button .title {
   display: inline-block;
   overflow: hidden;
   padding-top: 0.15em;
   text-align: center;
   text-overflow: ellipsis;
   white-space: nowrap;
 }
-
-/*
- * Style for the Network throttling menu button. This is shared between the Responsive
- * Design Mode and Network Monitor.
- */
-
-#network-throttling-menu {
-  padding-left: 2px;
-  padding-right: 10px;
-  background-position: right center;
-}
-