Bug 697505 - Rename LOG_FILE_NAME to LOG_FILE in Tab (r=sriram)
authorLucas Rocha <lucasr@mozilla.com>
Thu, 27 Oct 2011 14:18:34 +0100
changeset 83287 895980fb5339b39fb2e61549ff24accf0d428a4f
parent 83286 075341ad34eebe75267b025d67d585c34e501761
child 83288 83c5da37a89ba470757d03403129bbd12d9fa22c
push id519
push userakeybl@mozilla.com
push dateWed, 01 Feb 2012 00:38:35 +0000
treeherdermozilla-beta@788ea1ef610b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssriram
bugs697505
milestone10.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 697505 - Rename LOG_FILE_NAME to LOG_FILE in Tab (r=sriram) Better matches the semantics of the constant and more consistent with other parts of the code base.
embedding/android/Tab.java
--- a/embedding/android/Tab.java
+++ b/embedding/android/Tab.java
@@ -45,17 +45,17 @@ import android.graphics.drawable.Drawabl
 import android.os.AsyncTask;
 import android.provider.Browser;
 import android.util.Log;
 
 import java.util.Stack;
 
 public class Tab {
 
-    private static final String LOG_FILE_NAME = "Tab";
+    private static final String LOG_NAME = "Tab";
     private int id;
     private String url, title;
     private Drawable favicon, thumbnail;
     private Stack<HistoryEntry> history;
     private boolean loading;
     private boolean bookmark;
 
     static class HistoryEntry {
@@ -115,25 +115,25 @@ public class Tab {
     public Stack<HistoryEntry> getHistory() {
         return history;
     }
 
     public void updateURL(String url) {
 
         if(url != null && url.length() > 0) {
             this.url = new String(url);
-            Log.i(LOG_FILE_NAME, "Updated url: " + url + " for tab with id: " + this.id);
+            Log.i(LOG_NAME, "Updated url: " + url + " for tab with id: " + this.id);
             updateBookmark();
         }
     }
 
     public void updateTitle(String title) {
         if(title != null && title.length() > 0) {
             this.title = new String(title);
-            Log.i(LOG_FILE_NAME, "Updated title: " + title + " for tab with id: " + this.id);
+            Log.i(LOG_NAME, "Updated title: " + title + " for tab with id: " + this.id);
         }
     }
 
     public void setLoading(boolean loading) {
         this.loading = loading;
     }
 
     private void setBookmark(boolean bookmark) {
@@ -150,17 +150,17 @@ public class Tab {
     public HistoryEntry getLastHistoryEntry() {
        if (history.empty())
            return null;
        return history.peek();
     }
 
     public void updateFavicon(Drawable favicon) {
         this.favicon = favicon;
-        Log.i(LOG_FILE_NAME, "Updated favicon for tab with id: " + this.id);
+        Log.i(LOG_NAME, "Updated favicon for tab with id: " + this.id);
     }
  
     private void updateBookmark() {
         new CheckBookmarkTask().execute();
     }
 
     public void addBookmark() {
         new AddBookmarkTask().execute();