Bug 614865 - Addon about window does not handle overflow very well. r=dtownsend, a=blocking-final
authorBlair McBride <bmcbride@mozilla.com>
Tue, 07 Dec 2010 13:32:08 +1300
changeset 58732 88fee6b520bbeafc581aa8547fb4f1b131df4a9c
parent 58731 50b3455b84ba8fa817734516a1cb3922693d41e1
child 58733 3b2e0fcc3cac9b09a400da839002383de891b088
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdtownsend, blocking-final
bugs614865
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 614865 - Addon about window does not handle overflow very well. r=dtownsend, a=blocking-final
toolkit/mozapps/extensions/content/about.js
toolkit/mozapps/extensions/content/about.xul
toolkit/themes/pinstripe/mozapps/extensions/about.css
toolkit/themes/winstripe/mozapps/extensions/about.css
--- a/toolkit/mozapps/extensions/content/about.js
+++ b/toolkit/mozapps/extensions/content/about.js
@@ -44,17 +44,17 @@ function init() {
 
   if (addon.iconURL) {
     var extensionIcon = document.getElementById("extensionIcon");
     extensionIcon.src = addon.iconURL;
   }
 
   document.title = extensionsStrings.getFormattedString("aboutWindowTitle", [addon.name]);
   var extensionName = document.getElementById("extensionName");
-  extensionName.setAttribute("value", addon.name);
+  extensionName.textContent = addon.name;
 
   var extensionVersion = document.getElementById("extensionVersion");
   if (addon.version)
     extensionVersion.setAttribute("value", extensionsStrings.getFormattedString("aboutWindowVersionString", [addon.version]));
   else
     extensionVersion.hidden = true;
 
   var extensionDescription = document.getElementById("extensionDescription");
@@ -93,30 +93,32 @@ function init() {
     var groove = document.getElementById("groove");
     groove.hidden = true;
     var extensionDetailsBox = document.getElementById("extensionDetailsBox");
     extensionDetailsBox.hidden = true;
   }
 
   var acceptButton = document.documentElement.getButton("accept");
   acceptButton.label = extensionsStrings.getString("aboutWindowCloseButton");
+  
+  setTimeout(sizeToContent, 0);
 }
 
 function appendToList(aHeaderId, aNodeId, aItems) {
   var header = document.getElementById(aHeaderId);
   var node = document.getElementById(aNodeId);
 
   if (!aItems || aItems.length == 0) {
     header.hidden = true;
     return 0;
   }
 
   for (let i = 0; i < aItems.length; i++) {
     var label = document.createElement("label");
-    label.setAttribute("value", aItems[i]);
+    label.textContent = aItems[i];
     label.setAttribute("class", "contributor");
     node.appendChild(label);
   }
 
   return aItems.length;
 }
 
 function loadHomepage(aEvent) {
--- a/toolkit/mozapps/extensions/content/about.xul
+++ b/toolkit/mozapps/extensions/content/about.xul
@@ -54,20 +54,22 @@
   <script type="application/javascript" src="chrome://mozapps/content/extensions/about.js"/>
   <script type="application/javascript" src="chrome://global/content/contentAreaUtils.js"/>
 
   <stringbundleset id="aboutSet">
     <stringbundle id="extensionsStrings" src="chrome://mozapps/locale/extensions/extensions.properties"/>
   </stringbundleset>
 
   <vbox id="clientBox" flex="1">
-    <hbox class="basic-info" align="center">
-      <image id="extensionIcon"/>
-      <vbox>
-        <label id="extensionName" crop="end"/>
+    <hbox class="basic-info">
+      <vbox pack="center">
+        <image id="extensionIcon"/>
+      </vbox>
+      <vbox flex="1">
+        <label id="extensionName"/>
         <label id="extensionVersion" crop="end"/>
       </vbox>
     </hbox>
     <description id="extensionDescription" class="boxIndent"/>
 
     <separator id="groove" class="groove"/>
 
     <vbox id="extensionDetailsBox" flex="1">
--- a/toolkit/themes/pinstripe/mozapps/extensions/about.css
+++ b/toolkit/themes/pinstripe/mozapps/extensions/about.css
@@ -11,18 +11,18 @@
 }
 
 .basic-info {
   padding: 10px;
 }
 
 #extensionIcon {
   list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png");
-  max-width: 48px;
-  max-height: 48px;
+  max-width: 64px;
+  max-height: 64px;
   -moz-margin-end: 6px;
 }
 
 #genericAbout[addontype="theme"] #extensionIcon {
   list-style-image: url("chrome://mozapps/skin/extensions/themeGeneric.png");
 }
 
 #genericAbout[addontype="locale"] #extensionIcon {
--- a/toolkit/themes/winstripe/mozapps/extensions/about.css
+++ b/toolkit/themes/winstripe/mozapps/extensions/about.css
@@ -19,18 +19,18 @@
 
 
 .basic-info {
   padding: 10px;
 }
 
 #extensionIcon {
   list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png");
-  max-width: 48px;
-  max-height: 48px;
+  max-width: 64px;
+  max-height: 64px;
   -moz-margin-end: 6px;
 }
 
 #genericAbout[addontype="theme"] #extensionIcon {
   list-style-image: url("chrome://mozapps/skin/extensions/themeGeneric.png");
 }
 
 #genericAbout[addontype="locale"] #extensionIcon {