Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL; r=hiro
authorBrian Birtles <birtles@gmail.com>
Thu, 07 Sep 2017 15:50:21 +0900
changeset 429078 8852f9e7fb7e3d17e5817ba582d2105827398d61
parent 429077 e1c49835b46a0493720127604d7333029648860a
child 429079 0c2b838c91e479df3995d3f34f07e0991ae0cb20
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1357296
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL; r=hiro I'm not sure exactly how this works, but test_smilTextZoom.xhtml passes so this appears to be taken care of. MozReview-Commit-ID: C04XjX2rtZw
dom/smil/nsSMILCSSValueType.cpp
--- a/dom/smil/nsSMILCSSValueType.cpp
+++ b/dom/smil/nsSMILCSSValueType.cpp
@@ -719,28 +719,16 @@ ValueFromStringHelper(nsCSSPropertyID aP
     return result;
   }
 
   // Compute value
   aPresContext->StyleSet()->AsServo()->GetAnimationValues(servoDeclarationBlock,
                                                           aTargetElement,
                                                           aStyleContext->AsServo(),
                                                           result);
-  if (result.IsEmpty()) {
-    return result;
-  }
-
-  if (aPropID == eCSSProperty_font_size) {
-    // FIXME (bug 1357296): Divide out text-zoom, since SVG is supposed to
-    // ignore it.
-    if (aPresContext->EffectiveTextZoom() != 1.0) {
-      NS_WARNING("stylo: Dividing out text-zoom not yet supported"
-                 " (bug 1357296)");
-    }
-  }
 
   return result;
 }
 
 // static
 void
 nsSMILCSSValueType::ValueFromString(nsCSSPropertyID aPropID,
                                     Element* aTargetElement,