Bug 1599215 - Watchpoints do not work as expected after close Dev Tools. r=bhackett
authorJason Laster <jlaster@mozilla.com>
Thu, 05 Dec 2019 23:05:29 +0000
changeset 567939 87ee29f02a8844be5123fa7f26f885b27d33f6e7
parent 567938 7cb21c0caf6315278909f44c28eb0cf1cfab3531
child 567940 f0865dabd55a549de7cad0dcdede430ec3c83fd5
push id12493
push userffxbld-merge
push dateMon, 06 Jan 2020 15:38:57 +0000
treeherdermozilla-beta@63ae456b848d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbhackett
bugs1599215
milestone73.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1599215 - Watchpoints do not work as expected after close Dev Tools. r=bhackett Differential Revision: https://phabricator.services.mozilla.com/D56053
devtools/server/actors/thread.js
--- a/devtools/server/actors/thread.js
+++ b/devtools/server/actors/thread.js
@@ -281,16 +281,17 @@ const ThreadActor = ActorClassWithSpec(t
    * `exit`. The actor is truely destroyed in the `exit method`.
    */
   destroy: function() {
     dumpn("in ThreadActor.prototype.destroy");
     if (this._state == "paused") {
       this.doResume();
     }
 
+    this.removeAllWatchpoints();
     this._xhrBreakpoints = [];
     this._updateNetworkObserver();
 
     this._activeEventBreakpoints = new Set();
     this._debuggerNotificationObserver.removeListener(
       this._eventBreakpointListener
     );