Bug 1496610: Don't treat ~ (tilde) in paths as special. r=glandium
authorAdam Gashlin <agashlin@mozilla.com>
Thu, 04 Oct 2018 18:55:07 -0700
changeset 495476 874a07fdb045b725edc2aaa656a8620ff439ec10
parent 495475 85ac938c7c465de05292420422df9282743047f3
child 495477 9dd02ae2ee0ae93d12ea26e7a1d405427f090dc6
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1496610
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496610: Don't treat ~ (tilde) in paths as special. r=glandium This fixes treatment of Windows paths, where tilde is not special, particularly in short file names.
python/mozbuild/mozbuild/shellutil.py
--- a/python/mozbuild/mozbuild/shellutil.py
+++ b/python/mozbuild/mozbuild/shellutil.py
@@ -21,17 +21,17 @@ def _tokens2re(**tokens):
     # The final pattern matches either the above pattern, or an escaped
     # backslash, captured in the "escape" match group.
     return re.compile('(?:%s|%s)' % (nonescaped, r'(?P<escape>\\\\)'))
 
 UNQUOTED_TOKENS_RE = _tokens2re(
   whitespace=r'[\t\r\n ]+',
   quote=r'[\'"]',
   comment='#',
-  special=r'[<>&|`~(){}$;\*\?]',
+  special=r'[<>&|`(){}$;\*\?]',
   backslashed=r'\\[^\\]',
 )
 
 DOUBLY_QUOTED_TOKENS_RE = _tokens2re(
   quote='"',
   backslashedquote=r'\\"',
   special='\$',
   backslashed=r'\\[^\\"]',