Bug 947596 - Install RBTools from Git; r=mconley
authorGregory Szorc <gps@mozilla.com>
Fri, 24 Jan 2014 13:06:30 -0800
changeset 181061 86d2f0068a499f4fd1b3548955306eacfd73957e
parent 181060 76f4b3a1015450e9ce411635516e696a0eef508d
child 181105 fdc82b2c5584323dfd7deaaa0601e596d6725578
push id3343
push userffxbld
push dateMon, 17 Mar 2014 21:55:32 +0000
treeherdermozilla-beta@2f7d3415f79f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs947596
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 947596 - Install RBTools from Git; r=mconley RBTools as released on PyPI has a number of bugs and deficiencies with the Mercurial implementation. These have been fixed in an unreleased version of RBTools. Until RBTools with the desired patches is released to PyPI, we will install RBTools direct from its source repository. DONTBUILD (NPOTB)
tools/mach_commands.py
--- a/tools/mach_commands.py
+++ b/tools/mach_commands.py
@@ -296,17 +296,23 @@ class ReviewboardToolsProvider(MachComma
     @Command('rbt', category='devenv', allow_all_args=True,
         description='Run Reviewboard Tools')
     @CommandArgument('args', nargs='...', help='Arguments to rbt tool')
     def rbt(self, args):
         if not args:
             args = ['help']
 
         self._activate_virtualenv()
-        self.virtualenv_manager.install_pip_package('RBTools')
+        # We install RBTools from source control because the currently released
+        # version doesn't have patches that make Mercurial usable in many
+        # scenarios.
+        commit = '416a728292dff3f279e5d695f48a29749b51b77a'
+        self.virtualenv_manager.install_pip_package(
+            'git+https://github.com/reviewboard/rbtools.git@%s#egg=RBTools' %
+            commit)
 
         from rbtools.commands.main import main
 
         # main() doesn't accept arguments and instead reads from sys.argv. So,
         # we fake it out.
         sys.argv = ['rbt'] + args
         return main()