Bug 881777 - Use different height for search engine rows (r=sriram)
authorLucas Rocha <lucasr@mozilla.com>
Thu, 13 Jun 2013 16:58:39 +0100
changeset 156239 86cf65db4547a456210177d7e2b9aac793cebf56
parent 156238 723e4d6208e391e1c1e77d34a58be85dea614854
child 156240 d5ab1e6fced4d633382936268e49d52572f7f525
push id2961
push userlsblakk@mozilla.com
push dateMon, 28 Oct 2013 21:59:28 +0000
treeherdermozilla-beta@73ef4f13486f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssriram
bugs881777
milestone24.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 881777 - Use different height for search engine rows (r=sriram)
mobile/android/base/resources/layout/home_search_item_row.xml
mobile/android/base/resources/layout/search_engine_row.xml
mobile/android/base/resources/values/dimens.xml
--- a/mobile/android/base/resources/layout/home_search_item_row.xml
+++ b/mobile/android/base/resources/layout/home_search_item_row.xml
@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <org.mozilla.gecko.SearchEngineRow xmlns:android="http://schemas.android.com/apk/res/android"
                                    android:layout_width="fill_parent"
                                    android:layout_height="wrap_content"
-                                   android:minHeight="@dimen/page_row_height"
+                                   android:minHeight="@dimen/search_row_height"
                                    android:padding="7dp"/>
--- a/mobile/android/base/resources/layout/search_engine_row.xml
+++ b/mobile/android/base/resources/layout/search_engine_row.xml
@@ -11,16 +11,17 @@
 	                   android:layout_marginLeft="6dip"
 	                   android:layout_marginRight="6dip"
 	                   android:layout_centerVertical="true"
 	                   android:minWidth="@dimen/favicon_bg"
 	                   android:minHeight="@dimen/favicon_bg"/>
 
 	<org.mozilla.gecko.FlowLayout android:id="@+id/suggestion_layout"
 	                              android:layout_toRightOf="@id/suggestion_icon"
+	                              android:layout_centerVertical="true"
 	                              android:layout_width="wrap_content"
 	                              android:layout_height="wrap_content">
 
 	    <include layout="@layout/suggestion_item"
 	             android:id="@+id/suggestion_user_entered"/>
 
 	</org.mozilla.gecko.FlowLayout>
 
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -28,16 +28,19 @@
     <dimen name="favicon_size_small">16dp</dimen>
     <dimen name="favicon_size_large">32dp</dimen>
     <dimen name="favicon_bg">32dp</dimen>
     <dimen name="favicon_bg_radius">1dp</dimen>
 
     <!-- Page Row height -->
     <dimen name="page_row_height">64dp</dimen>
 
+    <!-- Search Engine Row height -->
+    <dimen name="search_row_height">48dp</dimen>
+
     <!-- Max width of the doorhanger on tablets -->
     <dimen name="doorhanger_width">400dp</dimen>
     <dimen name="doorhanger_input_width">250dp</dimen>
     <dimen name="doorhanger_spinner_textsize">9sp</dimen>
     <dimen name="doorhanger_padding">15dp</dimen>
     <dimen name="doorhanger_padding_spinners">10dp</dimen>
 
     <dimen name="flow_layout_spacing">6dp</dimen>