Bug 1400804 - First run tour - the Sync button is not visible. r=jwu
authorNevin Chen <cnevinchen@gmail.com>
Mon, 18 Sep 2017 18:02:50 +0800
changeset 431487 865bfef2c528b19d30b838760a84cc87f57886a6
parent 431486 48e2fba9e04e3d209b92a02d1e7198ac879703e9
child 431488 658b68ee4d0ae1b6c5ffb44ed38c310f50d4b283
push id7784
push userryanvm@gmail.com
push dateThu, 21 Sep 2017 00:40:13 +0000
treeherdermozilla-beta@efff4f307675 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjwu
bugs1400804
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1400804 - First run tour - the Sync button is not visible. r=jwu MozReview-Commit-ID: 65OnlR8MgnM
mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml
--- a/mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml
+++ b/mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml
@@ -35,36 +35,34 @@
 
         <TextView android:id="@+id/firstrun_subtext"
                   android:layout_width="@dimen/firstrun_content_width"
                   android:layout_height="wrap_content"
                   android:paddingTop="20dp"
                   android:gravity="center"
                   android:textAppearance="@style/TextAppearance.FirstrunRegular.Body"/>
 
-        <RelativeLayout
-            android:layout_width="match_parent"
-            android:layout_height="match_parent">
+        <View
+            android:layout_width="wrap_content"
+            android:layout_height="0dp"
+            android:layout_weight="1"
+            android:visibility="invisible"/>
 
-            <Button
-                android:id="@+id/welcome_account"
-                style="@style/Widget.Firstrun.Button"
-                android:layout_above="@+id/welcome_browse"
-                android:layout_gravity="center"
-                android:layout_centerHorizontal="true"
-                android:layout_marginBottom="20dp"
-                android:background="@drawable/button_background_action_photon_round"
-                android:text="@string/firstrun_signin_button"/>
+        <Button
+            android:id="@+id/welcome_account"
+            style="@style/Widget.Firstrun.Button"
+            android:layout_gravity="center"
+            android:layout_marginTop="30dp"
+            android:layout_marginBottom="20dp"
+            android:background="@drawable/button_background_action_photon_round"
+            android:text="@string/firstrun_signin_button"/>
 
-            <TextView
-                android:id="@+id/welcome_browse"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:layout_alignParentBottom="true"
-                android:layout_centerHorizontal="true"
-                android:layout_marginBottom="30dp"
-                android:text="@string/firstrun_welcome_button_browser"
-                android:textAllCaps="true"
-                android:textAppearance="@style/TextAppearance.Link"/>
-        </RelativeLayout>
+        <TextView
+            android:id="@+id/welcome_browse"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginBottom="30dp"
+            android:text="@string/firstrun_welcome_button_browser"
+            android:textAllCaps="true"
+            android:textAppearance="@style/TextAppearance.Link"/>
 
     </LinearLayout>
 </ScrollView>