Bug 1384969 - Stop forwarding browser console output to stdout with geckodriver; r=automatedtester,jgraham
authorAndreas Tolfsen <ato@sny.no>
Thu, 27 Jul 2017 16:55:34 +0100
changeset 420176 85b4584e1a838c8f44e6d342d2562e72c42c191f
parent 420175 a689645ca0f71cee221db9ec82282fdbad316ea3
child 420177 bda427f9dbeb7abf23bfaaecda3dfd3797f4e3f7
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersautomatedtester, jgraham
bugs1384969
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1384969 - Stop forwarding browser console output to stdout with geckodriver; r=automatedtester,jgraham browser.dom.window.dump.enabled causes the browser console messages to reach stdout, often confusing geckodriver users. We don’t recommend this preference in the Marionette server, although it is set in geckoinstance.py. This seems appropriate to the Gecko developer audience. Use of the dump() statement will of course still be possible in chrome level code. MozReview-Commit-ID: 7s7WlV2COBQ
testing/geckodriver/src/prefs.rs
--- a/testing/geckodriver/src/prefs.rs
+++ b/testing/geckodriver/src/prefs.rs
@@ -1,32 +1,28 @@
 use mozprofile::preferences::Pref;
 
 lazy_static! {
-    pub static ref DEFAULT: [(&'static str, Pref); 79] = [
+    pub static ref DEFAULT: [(&'static str, Pref); 78] = [
         // Disable automatic downloading of new releases
         ("app.update.auto", Pref::new(false)),
 
         // Disable automatically upgrading Firefox
         ("app.update.enabled", Pref::new(false)),
 
         // Increase the APZ content response timeout in tests to 1
         // minute.  This is to accommodate the fact that test environments
         // tends to be slower than production environments (with the
         // b2g emulator being the slowest of them all), resulting in the
         // production timeout value sometimes being exceeded and causing
         // false-positive test failures.
         //
         // (bug 1176798, bug 1177018, bug 1210465)
         ("apz.content_response_timeout", Pref::new(60000)),
 
-        // Enable the dump function, which sends messages to the system
-        // console
-        ("browser.dom.window.dump.enabled", Pref::new(true)),
-
         // Indicate that the download panel has been shown once so
         // that whichever download test runs first does not show the popup
         // inconsistently
         ("browser.download.panel.shown", Pref::new(true)),
 
         // Implicitly accept license
         ("browser.EULA.override", Pref::new(true)),