Bug 1202971 (part 2) - Fix compile warnings in toolkit/mozapps/update/tests. r=rstrong.
authorNicholas Nethercote <nnethercote@mozilla.com>
Tue, 15 Sep 2015 17:39:12 -0700
changeset 295316 84ffd9ae7cf1dfdfa58592ba632bae6029f4ac9e
parent 295315 3da17eef27503f8a48a0ff14fe591ae99f4849ae
child 295317 10df6e7a49fde9b5c2ebc857bf121b37ab369398
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrstrong
bugs1202971
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1202971 (part 2) - Fix compile warnings in toolkit/mozapps/update/tests. r=rstrong.
toolkit/mozapps/update/tests/TestAUSHelper.cpp
toolkit/mozapps/update/tests/moz.build
--- a/toolkit/mozapps/update/tests/TestAUSHelper.cpp
+++ b/toolkit/mozapps/update/tests/TestAUSHelper.cpp
@@ -240,17 +240,19 @@ int NS_main(int argc, NS_tchar **argv)
     mkdir(path, 0755);
     NS_tsnprintf(path, sizeof(path)/sizeof(path[0]),
                  NS_T("%s/%s/%s/%s"), NS_T("/tmp"), argv[2], argv[3], argv[4]);
     FILE * file = NS_tfopen(path, NS_T("w"));
     if (file) {
       NS_tfputs(NS_T("test"), file);
       fclose(file);
     }
-    symlink(path, argv[5]);
+    if (symlink(path, argv[5]) != 0) {
+      return 1;
+    }
     NS_tsnprintf(path, sizeof(path)/sizeof(path[0]),
                  NS_T("%s/%s"), NS_T("/tmp"), argv[2]);
     if (argc > 6 && !NS_tstrcmp(argv[6], NS_T("change-perm"))) {
       chmod(path, 0644);
     }
     return 0;
 #else
     // Not implemented on non-Unix platforms
--- a/toolkit/mozapps/update/tests/moz.build
+++ b/toolkit/mozapps/update/tests/moz.build
@@ -52,11 +52,8 @@ if CONFIG['MOZ_MAINTENANCE_SERVICE']:
 #DEFINES['DISABLE_UPDATER_AUTHENTICODE_CHECK'] = True
 
 if CONFIG['OS_ARCH'] == 'WINNT':
     DEFINES['UNICODE'] = True
     DEFINES['_UNICODE'] = True
     USE_STATIC_LIBS = True
     if CONFIG['GNU_CC']:
         WIN32_EXE_LDFLAGS += ['-municode']
-
-# XXX: We should fix these warnings
-ALLOW_COMPILER_WARNINGS = True