Bug 1575651 - Improve megabar behaviour when ui.popup.disable_autohide is enabled. r=dao
authorharry <htwyford@mozilla.com>
Mon, 26 Aug 2019 18:54:40 +0000
changeset 550435 84f6cbe4a30d492c0d01e58b65b7c146c93ed0d3
parent 550434 edcc94083dcf61f26153b6a3a08a837a2e519b41
child 550436 ca578c57a4f0047aeb60d5bb9f90f0e8ece008dc
push id11858
push userrmaries@mozilla.com
push dateThu, 29 Aug 2019 15:29:30 +0000
treeherdermozilla-beta@e9268d2f3233 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1575651
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1575651 - Improve megabar behaviour when ui.popup.disable_autohide is enabled. r=dao Differential Revision: https://phabricator.services.mozilla.com/D43079
browser/components/urlbar/UrlbarInput.jsm
--- a/browser/components/urlbar/UrlbarInput.jsm
+++ b/browser/components/urlbar/UrlbarInput.jsm
@@ -885,17 +885,17 @@ class UrlbarInput {
     this._layoutBreakoutPlaceholder.style.height = px(inputRect.height);
     this.textbox.before(this._layoutBreakoutPlaceholder);
     this.setAttribute("breakout", "true");
   }
 
   endLayoutBreakout(force) {
     if (
       !force &&
-      (this.isOpen ||
+      (this.view.isOpen ||
         (this.focused && !this.textbox.classList.contains("hidden-focus")))
     ) {
       return;
     }
     this.removeAttribute("breakout");
     if (this._layoutBreakoutPlaceholder) {
       this._layoutBreakoutPlaceholder.remove();
       this._layoutBreakoutPlaceholder = null;