Bug 1398656 - Always build the form autofill system add-on but disable it by default on release. r=lchang, a=gchang on a CLOSED TREE FIREFOX_56b13_RELBRANCH
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Wed, 13 Sep 2017 17:29:49 -0700
branchFIREFOX_56b13_RELBRANCH
changeset 430462 84e4b6c526bb553d3885ff63a93f5c4a780ca2ab
parent 430461 e7ef836b14ae5e92c080583c7b38c698f04f5fde
child 430465 108107830ffcc5a01feb9edea65994d5fc2976b4
push id7764
push userryanvm@gmail.com
push dateFri, 15 Sep 2017 15:15:51 +0000
treeherdermozilla-beta@84e4b6c526bb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslchang, gchang
bugs1398656
milestone56.0
Bug 1398656 - Always build the form autofill system add-on but disable it by default on release. r=lchang, a=gchang on a CLOSED TREE The pref will gradually be flipped via Shield to "detect" on release. MozReview-Commit-ID: LaiEub8v05t
browser/app/profile/firefox.js
browser/extensions/moz.build
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1688,20 +1688,23 @@ pref("browser.crashReports.unsubmittedCh
 // chancesUntilSuppress is how many times we'll show the unsubmitted
 // crash report notification across different days and shutdown
 // without a user choice before we suppress the notification for
 // some number of days.
 pref("browser.crashReports.unsubmittedCheck.chancesUntilSuppress", 4);
 pref("browser.crashReports.unsubmittedCheck.autoSubmit", false);
 
 // Preferences for the form autofill system extension
-// The value of "extensions.formautofill.available" can be "on", "off" and "detect".
-// The "detect" means it's enabled if conditions defined in the extension are met.
+// The truthy values of "extensions.formautofill.available" are "on" and "detect",
+// any other value means autofill isn't available.
+// "detect" means it's enabled if conditions defined in the extension are met.
 #ifdef NIGHTLY_BUILD
 pref("extensions.formautofill.available", "on");
+#elif MOZ_UPDATE_CHANNEL == release
+pref("extensions.formautofill.available", "staged-rollout");
 #else
 pref("extensions.formautofill.available", "detect");
 #endif
 pref("extensions.formautofill.addresses.enabled", true);
 pref("extensions.formautofill.creditCards.enabled", true);
 pref("extensions.formautofill.firstTimeUse", true);
 pref("extensions.formautofill.heuristics.enabled", true);
 pref("extensions.formautofill.loglevel", "Warn");
--- a/browser/extensions/moz.build
+++ b/browser/extensions/moz.build
@@ -5,37 +5,32 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 DIRS += [
     'activity-stream',
     'aushelper',
     'clicktoplay-rollout',
     'e10srollout',
     'followonsearch',
+    'formautofill',
     'onboarding',
     'pdfjs',
     'pocket',
     'screenshots',
     'shield-recipe-client',
     'webcompat',
 ]
 
 # Only include the following system add-ons if building Aurora or Nightly
 if not CONFIG['RELEASE_OR_BETA']:
     DIRS += [
         'flyweb',
         'presentation',
     ]
 
-# formautofill will be rolled out via balrog in release
-if CONFIG['MOZ_UPDATE_CHANNEL'] != 'release':
-    DIRS += [
-        'formautofill',
-    ]
-
 # Only include the following system add-ons if building DevEdition or Nightly
 if CONFIG['MOZ_DEV_EDITION'] or CONFIG['NIGHTLY_BUILD']:
     DIRS += [
         'webcompat-reporter',
     ]
 
 # Only include mortar system add-ons if we locally enable it
 if CONFIG['MOZ_MORTAR']: