Bug 1520238 - Measure memory by default when MOZ_PROFILER_STARTUP is set - r=mstange
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 30 Apr 2019 01:42:23 +0000
changeset 530682 83d4f96efbb57b55e2530cea3a9b2f662bcdc8f4
parent 530681 21dcb2db394431972b3af0d5ab02ad43f5c22edd
child 530683 75f2962e2a2e263854443f47936bc3bc3477b7c6
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1520238
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520238 - Measure memory by default when MOZ_PROFILER_STARTUP is set - r=mstange Differential Revision: https://phabricator.services.mozilla.com/D25712
tools/profiler/core/platform.cpp
--- a/tools/profiler/core/platform.cpp
+++ b/tools/profiler/core/platform.cpp
@@ -234,17 +234,17 @@ static uint32_t DefaultFeatures() {
          ProfilerFeature::Responsiveness;
 }
 
 // Extra default features when MOZ_PROFILER_STARTUP is set (even if not
 // available).
 static uint32_t StartupExtraDefaultFeatures() {
   // Enable mainthreadio by default for startup profiles as startup is heavy on
   // I/O operations, and main thread I/O is really important to see there.
-  return ProfilerFeature::MainThreadIO;
+  return ProfilerFeature::MainThreadIO | ProfilerFeature::Memory;
 }
 
 class PSMutex : public StaticMutex {};
 
 typedef BaseAutoLock<PSMutex&> PSAutoLock;
 
 // Only functions that take a PSLockRef arg can access CorePS's and ActivePS's
 // fields.