Bug 1454830 part 4 - Remove CSS_PROPERTY_VALUE_LIST_USES_COMMAS flag. r=emilio
authorXidorn Quan <me@upsuper.org>
Fri, 20 Apr 2018 20:38:12 +1000
changeset 468185 83921643241a46c747f33c84db6d6d7126835636
parent 468184 cd367de31d71ab49fe2849373912f31c0130ded0
child 468186 c313d03ea48ac4f5996582914da1748620e6fb16
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1454830
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1454830 part 4 - Remove CSS_PROPERTY_VALUE_LIST_USES_COMMAS flag. r=emilio MozReview-Commit-ID: 48CxJTdtku7
layout/style/nsCSSPropList.h
layout/style/nsCSSProps.h
--- a/layout/style/nsCSSPropList.h
+++ b/layout/style/nsCSSPropList.h
@@ -178,82 +178,82 @@ CSS_PROP_SHORTHAND(
     animation,
     Animation,
     CSS_PROPERTY_PARSE_FUNCTION,
     "")
 CSS_PROP_(
     animation-delay,
     animation_delay,
     AnimationDelay,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_TIME, // used by list parsing
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-direction,
     animation_direction,
     AnimationDirection,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kAnimationDirectionKTable,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-duration,
     animation_duration,
     AnimationDuration,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_TIME | VARIANT_NONNEGATIVE_DIMENSION, // used by list parsing
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-fill-mode,
     animation_fill_mode,
     AnimationFillMode,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kAnimationFillModeKTable,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-iteration-count,
     animation_iteration_count,
     AnimationIterationCount,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD | VARIANT_NUMBER, // used by list parsing
     kAnimationIterationCountKTable,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-name,
     animation_name,
     AnimationName,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     // FIXME: The spec should say something about 'inherit' and 'initial'
     // not being allowed.
     VARIANT_NONE | VARIANT_IDENTIFIER_NO_INHERIT | VARIANT_STRING, // used by list parsing
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-play-state,
     animation_play_state,
     AnimationPlayState,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kAnimationPlayStateKTable,
     eStyleAnimType_None)
 CSS_PROP_(
     animation-timing-function,
     animation_timing_function,
     AnimationTimingFunction,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD | VARIANT_TIMING_FUNCTION, // used by list parsing
     kTransitionTimingFunctionKTable,
     eStyleAnimType_None)
 CSS_PROP_(
     -moz-appearance,
     _moz_appearance,
     CSS_PROP_DOMPROP_PREFIXED(Appearance),
@@ -276,35 +276,35 @@ CSS_PROP_SHORTHAND(
     background,
     Background,
     CSS_PROPERTY_PARSE_FUNCTION,
     "")
 CSS_PROP_(
     background-attachment,
     background_attachment,
     BackgroundAttachment,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kImageLayerAttachmentKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     background-blend-mode,
     background_blend_mode,
     BackgroundBlendMode,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "layout.css.background-blend-mode.enabled",
     VARIANT_KEYWORD, // used by list parsing
     kBlendModeKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     background-clip,
     background_clip,
     BackgroundClip,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kBackgroundClipKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     background-color,
     background_color,
     BackgroundColor,
@@ -312,72 +312,68 @@ CSS_PROP_(
     "",
     VARIANT_HC,
     nullptr,
     eStyleAnimType_ComplexColor)
 CSS_PROP_(
     background-image,
     background_image,
     BackgroundImage,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_IMAGE, // used by list parsing
     nullptr,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     background-origin,
     background_origin,
     BackgroundOrigin,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kBackgroundOriginKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_SHORTHAND(
     background-position,
     background_position,
     BackgroundPosition,
     CSS_PROPERTY_PARSE_FUNCTION,
     "")
 CSS_PROP_(
     background-position-x,
     background_position_x,
     BackgroundPositionX,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kImageLayerPositionKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     background-position-y,
     background_position_y,
     BackgroundPositionY,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kImageLayerPositionKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     background-repeat,
     background_repeat,
     BackgroundRepeat,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kImageLayerRepeatKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     background-size,
     background_size,
     BackgroundSize,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kImageLayerSizeKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     -moz-binding,
     _moz_binding,
     CSS_PROP_DOMPROP_PREFIXED(Binding),
@@ -865,18 +861,17 @@ CSS_PROP_(
     "",
     VARIANT_HK,
     kBoxPackKTable,
     eStyleAnimType_Discrete) // XXX bug 3935
 CSS_PROP_(
     box-shadow,
     box_shadow,
     BoxShadow,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
         // NOTE: some components must be nonnegative
     "",
     VARIANT_COLOR | VARIANT_LENGTH | VARIANT_CALC | VARIANT_INHERIT | VARIANT_NONE,
     kBoxShadowTypeKTable,
     eStyleAnimType_Shadow)
 CSS_PROP_(
     box-sizing,
     box_sizing,
@@ -1081,17 +1076,16 @@ CSS_PROP_(
     eStyleAnimType_Discrete)
 #ifndef CSS_PROP_LIST_EXCLUDE_INTERNAL
 CSS_PROP_(
     // Only intended to be used internally by Mozilla, so prefixed.
     -moz-context-properties,
     _moz_context_properties,
     CSS_PROP_DOMPROP_PREFIXED(ContextProperties),
     CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS |
         CSS_PROPERTY_INTERNAL,
     "",
     0,
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     -moz-control-character-visibility,
     _moz_control_character_visibility,
@@ -1119,18 +1113,17 @@ CSS_PROP_(
     "",
     VARIANT_INHERIT | VARIANT_NONE,
     nullptr,
     eStyleAnimType_Discrete) // XXX bug 137285
 CSS_PROP_(
     cursor,
     cursor,
     Cursor,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kCursorKTable,
     eStyleAnimType_Discrete)
 #ifndef CSS_PROP_LIST_ONLY_COMPONENTS_OF_ALL_SHORTHAND
 CSS_PROP_(
     direction,
     direction,
@@ -1475,18 +1468,17 @@ CSS_PROP_(
     "",
     VARIANT_HMK,
     kFontVariantPositionKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     font-variation-settings,
     font_variation_settings,
     FontVariationSettings,
-    CSS_PROPERTY_VALUE_PARSER_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_VALUE_PARSER_FUNCTION,
     "layout.css.font-variations.enabled",
     0,
     nullptr,
     eStyleAnimType_Custom)
 CSS_PROP_(
     font-weight,
     font_weight,
     FontWeight,
@@ -1959,99 +1951,95 @@ CSS_PROP_SHORTHAND(
     mask,
     Mask,
     CSS_PROPERTY_PARSE_FUNCTION,
     "")
 CSS_PROP_(
     mask-clip,
     mask_clip,
     MaskClip,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kMaskClipKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     mask-composite,
     mask_composite,
     MaskComposite,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kImageLayerCompositeKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     mask-image,
     mask_image,
     MaskImage,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_IMAGE, // used by list parsing
     nullptr,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     mask-mode,
     mask_mode,
     MaskMode,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kImageLayerModeKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     mask-origin,
     mask_origin,
     MaskOrigin,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kMaskOriginKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_SHORTHAND(
     mask-position,
     mask_position,
     MaskPosition,
     CSS_PROPERTY_PARSE_FUNCTION,
     "")
 CSS_PROP_(
     mask-position-x,
     mask_position_x,
     MaskPositionX,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kImageLayerPositionKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     mask-position-y,
     mask_position_y,
     MaskPositionY,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kImageLayerPositionKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     mask-repeat,
     mask_repeat,
     MaskRepeat,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     VARIANT_KEYWORD, // used by list parsing
     kImageLayerRepeatKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     mask-size,
     mask_size,
     MaskSize,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kImageLayerSizeKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     mask-type,
     mask_type,
     MaskType,
@@ -2714,18 +2702,17 @@ CSS_PROP_(
     "layout.css.scroll-behavior.property-enabled",
     VARIANT_HK,
     kScrollBehaviorKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     scroll-snap-coordinate,
     scroll_snap_coordinate,
     ScrollSnapCoordinate,
-    CSS_PROPERTY_VALUE_PARSER_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_VALUE_PARSER_FUNCTION,
     "layout.css.scroll-snap.enabled",
     0,
     kImageLayerPositionKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     scroll-snap-destination,
     scroll_snap_destination,
     ScrollSnapDestination,
@@ -2852,18 +2839,17 @@ CSS_PROP_(
     "",
     0,
     kContextPatternKTable,
     eStyleAnimType_PaintServer)
 CSS_PROP_(
     stroke-dasharray,
     stroke_dasharray,
     StrokeDasharray,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
         // NOTE: Internal values have range restrictions.
     "",
     0,
     kStrokeContextValueKTable,
     eStyleAnimType_Custom)
 CSS_PROP_(
     stroke-dashoffset,
     stroke_dashoffset,
@@ -3093,18 +3079,17 @@ CSS_PROP_(
     "",
     VARIANT_HK,
     kTextRenderingKTable,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     text-shadow,
     text_shadow,
     TextShadow,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
         // NOTE: some components must be nonnegative
     "",
     VARIANT_COLOR | VARIANT_LENGTH | VARIANT_CALC | VARIANT_INHERIT | VARIANT_NONE,
     nullptr,
     eStyleAnimType_Shadow)
 CSS_PROP_(
     -moz-text-size-adjust,
     _moz_text_size_adjust,
@@ -3235,45 +3220,44 @@ CSS_PROP_SHORTHAND(
     transition,
     Transition,
     CSS_PROPERTY_PARSE_FUNCTION,
     "")
 CSS_PROP_(
     transition-delay,
     transition_delay,
     TransitionDelay,
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_TIME, // used by list parsing
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     transition-duration,
     transition_duration,
     TransitionDuration,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_TIME | VARIANT_NONNEGATIVE_DIMENSION, // used by list parsing
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     transition-property,
     transition_property,
     TransitionProperty,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     VARIANT_IDENTIFIER | VARIANT_NONE | VARIANT_ALL, // used only in shorthand
     nullptr,
     eStyleAnimType_None)
 CSS_PROP_(
     transition-timing-function,
     transition_timing_function,
     TransitionTimingFunction,
-    CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    0,
     "",
     VARIANT_KEYWORD | VARIANT_TIMING_FUNCTION, // used by list parsing
     kTransitionTimingFunctionKTable,
     eStyleAnimType_None)
 CSS_PROP_(
     translate,
     translate,
     Translate,
@@ -3377,18 +3361,17 @@ CSS_PROP_(
     "",
     VARIANT_AHKLP | VARIANT_CALC,
     kWidthKTable,
     eStyleAnimType_Coord)
 CSS_PROP_(
     will-change,
     will_change,
     WillChange,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_VALUE_LIST_USES_COMMAS,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     nullptr,
     eStyleAnimType_Discrete)
 CSS_PROP_(
     -moz-window-dragging,
     _moz_window_dragging,
     CSS_PROP_DOMPROP_PREFIXED(WindowDragging),
@@ -3397,17 +3380,17 @@ CSS_PROP_(
     VARIANT_HK,
     kWindowDraggingKTable,
     eStyleAnimType_Discrete)
 #ifndef CSS_PROP_LIST_EXCLUDE_INTERNAL
 CSS_PROP_(
     -moz-window-opacity,
     _moz_window_opacity,
     CSS_PROP_DOMPROP_PREFIXED(WindowOpacity),
-    CSS_PROPERTY_INTERNAL | 0,
+    CSS_PROPERTY_INTERNAL,
     "",
     VARIANT_HN,
     nullptr,
     eStyleAnimType_float)
 CSS_PROP_(
     -moz-window-shadow,
     _moz_window_shadow,
     CSS_PROP_DOMPROP_PREFIXED(WindowShadow),
--- a/layout/style/nsCSSProps.h
+++ b/layout/style/nsCSSProps.h
@@ -119,18 +119,16 @@
 #define VARIANT_LPCALC (VARIANT_LCALC | VARIANT_PERCENT)
 #define VARIANT_LNCALC (VARIANT_LCALC | VARIANT_NUMBER)
 #define VARIANT_LPNCALC (VARIANT_LNCALC | VARIANT_PERCENT)
 #define VARIANT_IMAGE   (VARIANT_URL | VARIANT_NONE | VARIANT_GRADIENT | \
                         VARIANT_IMAGE_RECT | VARIANT_ELEMENT)
 
 // Flags for the kFlagsTable bitfield (flags_ in nsCSSPropList.h)
 
-#define CSS_PROPERTY_VALUE_LIST_USES_COMMAS       (1<<1) /* otherwise spaces */
-
 // Define what mechanism the CSS parser uses for parsing the property.
 // See CSSParserImpl::ParseProperty(nsCSSPropertyID).  Don't use 0 so that
 // we can verify that every property sets one of the values.
 #define CSS_PROPERTY_PARSE_PROPERTY_MASK          (7<<9)
 #define CSS_PROPERTY_PARSE_INACCESSIBLE           (1<<9)
 #define CSS_PROPERTY_PARSE_FUNCTION               (2<<9)
 
 // See CSSParserImpl::ParseSingleValueProperty and comment above