Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 5 - Correct pref checks, r=dimi
authorAndrea Marchesini <amarchesini@mozilla.com>
Thu, 14 Mar 2019 17:49:05 +0000
changeset 521919 8337beedb635
parent 521918 d5c86748df92
child 521920 d3889d245691
push id10870
push usernbeleuzu@mozilla.com
push dateFri, 15 Mar 2019 20:00:07 +0000
treeherdermozilla-beta@c594aee5b7a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdimi
bugs1533074
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 5 - Correct pref checks, r=dimi Differential Revision: https://phabricator.services.mozilla.com/D23104
netwerk/url-classifier/AsyncUrlChannelClassifier.cpp
--- a/netwerk/url-classifier/AsyncUrlChannelClassifier.cpp
+++ b/netwerk/url-classifier/AsyncUrlChannelClassifier.cpp
@@ -411,17 +411,18 @@ bool FeatureData::MaybeCompleteClassific
   nsresult rv = mFeature->GetSkipHostList(skipList);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     UC_LOG(
         ("FeatureData::MaybeCompleteClassification[%p] - error. Let's move on",
          this));
     return true;
   }
 
-  if (nsContentUtils::IsURIInList(mBlacklistTables[0]->URI(), skipList)) {
+  if (!mBlacklistTables.IsEmpty() &&
+      nsContentUtils::IsURIInList(mBlacklistTables[0]->URI(), skipList)) {
     UC_LOG(
         ("FeatureData::MaybeCompleteClassification[%p] - uri found in skiplist",
          this));
     return true;
   }
 
   nsAutoCString list;
   list.Assign(mHostInPrefTables[nsIUrlClassifierFeature::blacklist]);