Bug 1264434 - Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js. r=bgrins
authorSami Jaktholm <sjakthol@outlook.com>
Sun, 05 Jun 2016 05:49:12 +0000
changeset 339414 824355c9efe23d83f7e67a4b2c9e0e837f7c7771
parent 339413 c6efb920dd67e68956499bcb5d0e8127f9b1ca34
child 339415 c37d634eba0d4e8dc8743b77fe787955a79457ca
child 340632 11010bdd45ac89b20b4f0414a6a70e4f11301087
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1264434
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1264434 - Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js. r=bgrins String.prototype.contains was removed from Firefox 48 completely after it was renamed to String.prototype.includes. The test includes a call to .contains() which is triggered whenever random JavaScript error occurs during the test (hence the intermittency). MozReview-Commit-ID: 7nbRm94JM7O
devtools/client/webconsole/test/browser_webconsole_bug_597136_network_requests_from_chrome.js
--- a/devtools/client/webconsole/test/browser_webconsole_bug_597136_network_requests_from_chrome.js
+++ b/devtools/client/webconsole/test/browser_webconsole_bug_597136_network_requests_from_chrome.js
@@ -11,17 +11,17 @@
 const TEST_URI = "http://example.com/";
 
 var good = true;
 var listener = {
   QueryInterface: XPCOMUtils.generateQI([ Ci.nsIObserver ]),
   observe: function (subject) {
     if (subject instanceof Ci.nsIScriptError &&
         subject.category === "XPConnect JavaScript" &&
-        subject.sourceName.contains("webconsole")) {
+        subject.sourceName.includes("webconsole")) {
       good = false;
     }
   }
 };
 
 var xhr;
 
 function test() {