Bug 1447145 [wpt PR 10100] - Handle options for add_untested_idls, a=testonly
authorLuke Bjerring <lukebjerring@users.noreply.github.com>
Mon, 09 Apr 2018 17:39:33 +0000
changeset 467158 8100de6989ad49533de211d3a325d7e05323fdb6
parent 467157 ea2668153d4af4aee66e628882b26a5387c02e3c
child 467159 cefae2f1269d640db33741d615408bd6686a2e80
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1447145, 10100
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1447145 [wpt PR 10100] - Handle options for add_untested_idls, a=testonly Automatic update from web-platform-testsHandle options for add_untested_idls (#10100) wpt-commits: df2e8038d83a8573de683c38fde2211bcc3057a2 wpt-pr: 10100 wpt-commits: df2e8038d83a8573de683c38fde2211bcc3057a2 wpt-pr: 10100
testing/web-platform/tests/resources/idlharness.js
--- a/testing/web-platform/tests/resources/idlharness.js
+++ b/testing/web-platform/tests/resources/idlharness.js
@@ -172,33 +172,33 @@ self.IdlArray = function()
 IdlArray.prototype.add_idls = function(raw_idls, options)
 //@{
 {
     /** Entry point.  See documentation at beginning of file. */
     this.internal_add_idls(WebIDL2.parse(raw_idls), options);
 };
 
 //@}
-IdlArray.prototype.add_untested_idls = function(raw_idls)
+IdlArray.prototype.add_untested_idls = function(raw_idls, options)
 //@{
 {
     /** Entry point.  See documentation at beginning of file. */
     var parsed_idls = WebIDL2.parse(raw_idls);
     for (var i = 0; i < parsed_idls.length; i++)
     {
         parsed_idls[i].untested = true;
         if ("members" in parsed_idls[i])
         {
             for (var j = 0; j < parsed_idls[i].members.length; j++)
             {
                 parsed_idls[i].members[j].untested = true;
             }
         }
     }
-    this.internal_add_idls(parsed_idls);
+    this.internal_add_idls(parsed_idls, options);
 };
 
 //@}
 IdlArray.prototype.internal_add_idls = function(parsed_idls, options)
 //@{
 {
     /**
      * Internal helper called by add_idls() and add_untested_idls().
@@ -269,24 +269,24 @@ IdlArray.prototype.internal_add_idls = f
             {
                 this["includes"][parsed_idl.target] = [];
             }
             this["includes"][parsed_idl.target].push(parsed_idl["includes"]);
             return;
         }
 
         parsed_idl.array = this;
+        if (should_skip(parsed_idl.name))
+        {
+            return;
+        }
         if (parsed_idl.name in this.members)
         {
             throw "Duplicate identifier " + parsed_idl.name;
         }
-        if (should_skip(parsed_idl.name))
-        {
-            return;
-        }
         switch(parsed_idl.type)
         {
         case "interface":
             this.members[parsed_idl.name] =
                 new IdlInterface(parsed_idl, /* is_callback = */ false, /* is_mixin = */ false);
             break;
 
         case "interface mixin":