Bug 562052: The version number should be shown in the list view for all types of add-ons. r=Unfocused
authorDave Townsend <dtownsend@oxymoronical.com>
Mon, 28 Jun 2010 12:43:53 -0700
changeset 46368 80fa5e48c29564408a20ed2f115f080634293cf2
parent 46367 5a7d3c0765667a6bb15ca72148c44d9f378b1ae4
child 46369 680af2301ba30b014fa15f08b453eef22e7347ee
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersUnfocused
bugs562052
milestone1.9.3a6pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 562052: The version number should be shown in the list view for all types of add-ons. r=Unfocused
toolkit/mozapps/extensions/content/extensions.xml
toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
toolkit/themes/pinstripe/mozapps/extensions/extensions.css
toolkit/themes/winstripe/mozapps/extensions/extensions.css
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -682,16 +682,17 @@
     <content>
       <xul:vbox>
         <xul:image anonid="icon" class="icon"/>
         <xul:spacer flex="1"/>
       </xul:vbox>
       <xul:vbox flex="1" class="fade">
         <xul:hbox class="name-container">
           <xul:label anonid="name" class="name" xbl:inherits="value=name"/>
+          <xul:label anonid="version" class="version"/>
           <xul:label class="disabled-postfix" value="&addon.disabled.postfix;"/>
         </xul:hbox>
         <xul:label anonid="creator" class="creator"/>
         <xul:description anonid="description" class="description" flex="1"/>
       </xul:vbox>
       <xul:vbox align="end">
         <xul:vbox class="details-container fade">
           <xul:hbox anonid="incompatible-container"
@@ -778,16 +779,18 @@
           this._homepage.hidden = true;
           numExtraDetails--;
         }
 
         var iconURL = this.mAddon.iconURL;
         if (iconURL)
           this._icon.src = iconURL;
 
+        this._version.value = this.mAddon.version;
+
         var creator = this.mAddon.creator;
         var creatorURL = this.mAddon.creatorURL;
         // XXxunf api
         this._creator.setCreator(creator, creatorURL || homepageURL);
 
         this._description.textContent = this.mAddon.description;
 
         if (numExtraDetails == 0)
@@ -819,16 +822,19 @@
       <field name="_creator">
         document.getAnonymousElementByAttribute(this, "anonid",
                                                 "creator");
       </field>
       <field name="_homepage">
         document.getAnonymousElementByAttribute(this, "anonid",
                                                 "homepage");
       </field>
+      <field name="_version">
+        document.getAnonymousElementByAttribute(this, "anonid", "version");
+      </field>
       <field name="_icon">
         document.getAnonymousElementByAttribute(this, "anonid", "icon");
       </field>
       <field name="_size">
         document.getAnonymousElementByAttribute(this, "anonid",
                                                 "formatted-size");
       </field>
       <field name="_dateUpdated">
--- a/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
@@ -327,17 +327,18 @@
 .addon[type="plugin"] .icon {
   list-style-image: url("chrome://mozapps/skin/plugins/pluginGeneric.png");
 }
 
 .addon .name-container {
   -moz-box-align: end;
 }
 
-.addon .name {
+.addon .name,
+.addon .version {
   font-size: 150%;
   margin-bottom: 0px;
 }
 
 .addon .disabled-postfix {
   font-size: 130%;
 }
 
--- a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
@@ -327,17 +327,18 @@
 .addon[type="plugin"] .icon {
   list-style-image: url("chrome://mozapps/skin/plugins/pluginGeneric.png");
 }
 
 .addon .name-container {
   -moz-box-align: end;
 }
 
-.addon .name {
+.addon .name,
+.addon .version {
   font-size: 150%;
   margin-bottom: 0px;
 }
 
 .addon .disabled-postfix {
   font-size: 130%;
 }
 
--- a/toolkit/themes/winstripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/winstripe/mozapps/extensions/extensions.css
@@ -327,17 +327,18 @@
 .addon[type="plugin"] .icon {
   list-style-image: url("chrome://mozapps/skin/plugins/pluginGeneric.png");
 }
 
 .addon .name-container {
   -moz-box-align: end;
 }
 
-.addon .name {
+.addon .name,
+.addon .version {
   font-size: 150%;
   margin-bottom: 0px;
 }
 
 .addon .disabled-postfix {
   font-size: 130%;
 }