Bug 1540839 - Update tests for frameloader browsing context reuse; r=nika
authorKyle Machulis <kyle@nonpolynomial.com>
Thu, 18 Apr 2019 15:32:40 -0700
changeset 532670 8069a95120e0660496da92f8edb6c8fd89180b66
parent 532669 40acaa39dc45c973d2eebc47aab8f5f94f2397e3
child 532671 1dca842b1dd83a06703ef0b9d5ed8d3ad52e4662
push id11270
push userrgurzau@mozilla.com
push dateWed, 15 May 2019 15:07:19 +0000
treeherdermozilla-beta@571bc76da583 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnika
bugs1540839
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1540839 - Update tests for frameloader browsing context reuse; r=nika Differential Revision: https://phabricator.services.mozilla.com/D28760
toolkit/components/remotebrowserutils/tests/browser/browser_oopProcessSwap.js
--- a/toolkit/components/remotebrowserutils/tests/browser/browser_oopProcessSwap.js
+++ b/toolkit/components/remotebrowserutils/tests/browser/browser_oopProcessSwap.js
@@ -40,17 +40,17 @@ add_task(async function oopProcessSwap()
 
       return {
         location: data.location,
         browsingContextId: iframe.browsingContext.id,
       };
     });
 
     is(browser.browsingContext.getChildren().length, 1);
-    todo(frameId == oopinfo.browsingContextId, "BrowsingContext should not have changed");
+    is(frameId, oopinfo.browsingContextId, `BrowsingContext should not have changed (${frameId} != ${oopinfo.browsingContextId})`);
     is(oopinfo.location, WEB, "correct location");
   });
 
   await BrowserTestUtils.closeWindow(win);
 });
 
 add_task(async function oopOriginProcessSwap() {
   const COM_DUMMY = httpURL("dummy_page.html", "https://example.com/");
@@ -94,15 +94,15 @@ add_task(async function oopOriginProcess
 
       return {
         location: data.location,
         browsingContextId: iframe.browsingContext.id,
       };
     });
 
     is(browser.browsingContext.getChildren().length, 1);
-    todo(frameId == oopinfo.browsingContextId, "BrowsingContext should not have changed");
+    is(frameId, oopinfo.browsingContextId, `BrowsingContext should not have changed (${frameId} != ${oopinfo.browsingContextId})`);
     is(oopinfo.location, ORG_POSTMSG, "correct location");
   });
 
   await BrowserTestUtils.closeWindow(win);
 });