Bug 1529939 - Remove JSVAL_TYPE_MISSING. r=bzbarsky,jandem
authorTom Schuster <evilpies@gmail.com>
Tue, 26 Feb 2019 08:48:01 +0000
changeset 519067 805264e071d9071f73fead2d45e75538d9922f2a
parent 519066 355463041f49af2535bd8d13da17c66a77bc0ef8
child 519068 3c172c9d894541142342901bcaecb73715099d0e
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky, jandem
bugs1529939
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1529939 - Remove JSVAL_TYPE_MISSING. r=bzbarsky,jandem Differential Revision: https://phabricator.services.mozilla.com/D20936
dom/bindings/Codegen.py
js/public/Value.h
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -9909,17 +9909,17 @@ class CGStaticMethodJitinfo(CGGeneric):
     """
     def __init__(self, method):
         CGGeneric.__init__(
             self,
             "\n"
             "static const JSJitInfo %s_methodinfo = {\n"
             "  { (JSJitGetterOp)%s },\n"
             "  { prototypes::id::_ID_Count }, { 0 }, JSJitInfo::StaticMethod,\n"
-            "  JSJitInfo::AliasEverything, JSVAL_TYPE_MISSING, false, false,\n"
+            "  JSJitInfo::AliasEverything, JSVAL_TYPE_OBJECT, false, false,\n"
             "  false, false, 0\n"
             "};\n" %
             (IDLToCIdentifier(method.identifier.name),
              CppKeywords.checkMethodName(
                  IDLToCIdentifier(method.identifier.name))))
 
 
 def getEnumValueName(value):
--- a/js/public/Value.h
+++ b/js/public/Value.h
@@ -59,20 +59,18 @@ enum JSValueType : uint8_t {
   JSVAL_TYPE_NULL = 0x04,
   JSVAL_TYPE_MAGIC = 0x05,
   JSVAL_TYPE_STRING = 0x06,
   JSVAL_TYPE_SYMBOL = 0x07,
   JSVAL_TYPE_PRIVATE_GCTHING = 0x08,
   JSVAL_TYPE_BIGINT = 0x09,
   JSVAL_TYPE_OBJECT = 0x0c,
 
-  // These never appear in a jsval; they are only provided as an out-of-band
-  // value.
-  JSVAL_TYPE_UNKNOWN = 0x20,
-  JSVAL_TYPE_MISSING = 0x21
+  // This type never appears in a Value; it's only an out-of-band value.
+  JSVAL_TYPE_UNKNOWN = 0x20
 };
 
 namespace JS {
 enum class ValueType : uint8_t {
   Double = JSVAL_TYPE_DOUBLE,
   Int32 = JSVAL_TYPE_INT32,
   Boolean = JSVAL_TYPE_BOOLEAN,
   Undefined = JSVAL_TYPE_UNDEFINED,