Bug 1445216 - remove useless initialization of variable `atFirstColumn` in nsPlainTextSerializer::Write. r=bz
authorPetru Gurita <petru.gurita1@gmail.com>
Tue, 26 Jun 2018 23:23:43 +0300
changeset 479438 803ff4b978c45629e313b4277b575a12c86c75ea
parent 479437 a9c85d545b473bd6f1439d7389f53b4e8c7c250c
child 479439 6c5c7f763b65c4eab3ec5f61945366308fe5b4ca
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1445216
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1445216 - remove useless initialization of variable `atFirstColumn` in nsPlainTextSerializer::Write. r=bz The `atFirstColumn` variable is set on both branches of an 'if' before it's read. MozReview-Commit-ID: 2HezoWgnOb1
dom/base/nsPlainTextSerializer.cpp
--- a/dom/base/nsPlainTextSerializer.cpp
+++ b/dom/base/nsPlainTextSerializer.cpp
@@ -1628,17 +1628,17 @@ nsPlainTextSerializer::Write(const nsASt
     if (!mCurrentLine.IsEmpty()) {
       FlushLine();
     }
 
     // Put the mail quote "> " chars in, if appropriate.
     // Have to put it in before every line.
     while(bol<totLen) {
       bool outputQuotes = mAtFirstColumn;
-      bool atFirstColumn = mAtFirstColumn;
+      bool atFirstColumn;
       bool outputLineBreak = false;
       bool spacesOnly = true;
 
       // Find one of '\n' or '\r' using iterators since nsAString
       // doesn't have the old FindCharInSet function.
       nsAString::const_iterator iter;           str.BeginReading(iter);
       nsAString::const_iterator done_searching; str.EndReading(done_searching);
       iter.advance(bol);