Bug 1483592 [wpt PR 12506] - Tweak cover blending in wpt/svg/render/reftests/blending-00[12].svg, a=testonly
authorFredrik Söderquist <fs@opera.com>
Thu, 16 Aug 2018 21:55:36 +0000
changeset 487251 7fe0668cdda4209ba94f8e9f6a61c1f49625c690
parent 487250 0207dddd3977b3a4e2c9a329ec4089bab5ded8dc
child 487252 b5aab38ab9085bd97d841f636478c9ba7842b06f
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1483592, 12506, 866928, 1175825, 583277
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1483592 [wpt PR 12506] - Tweak cover blending in wpt/svg/render/reftests/blending-00[12].svg, a=testonly Automatic update from web-platform-testsTweak cover blending in wpt/svg/render/reftests/blending-00[12].svg Set 'mix-blend-mode' to 'normal' on the stroked rects that make up the "edge cover". Hopefully this avoids aliasing artifacts on the edge cover itself. In blending-002.svg, localize the use of (non-auto) isolation to the content of the test. BUG=866928 Change-Id: I269e01a4d814f7fd8e202ffdf71c1a1d5dc48347 Reviewed-on: https://chromium-review.googlesource.com/1175825 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583277} -- wpt-commits: a8e055ac707c4a8e5e166ff469cd777b0f78363f wpt-pr: 12506
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/svg/render/reftests/blending-001.svg
testing/web-platform/tests/svg/render/reftests/blending-002.svg
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -636417,25 +636417,25 @@
    "04d8d3025ee0f039a05bdd439f2dc02c13f49a23",
    "reftest"
   ],
   "svg/render/reftests/blending-001-ref.svg": [
    "dcd39a8a1d5b2c76038a50506e661d3c5513a847",
    "support"
   ],
   "svg/render/reftests/blending-001.svg": [
-   "2278019cc736eeb517e5f4f619211e5ce0847cf1",
+   "f8fcf9fae49363d94157b1a5c9c50e8d6c997d15",
    "reftest"
   ],
   "svg/render/reftests/blending-002-ref.svg": [
    "df6f29fa3bc0f122bcc69d8ba354bfffe4579189",
    "support"
   ],
   "svg/render/reftests/blending-002.svg": [
-   "01e180f23a5b35b27e80ceee39087e1fa3118c6b",
+   "d74333c96fd7e4974bebf51544e961c63f3f2cea",
    "reftest"
   ],
   "svg/rendering/order/z-index-ref.svg": [
    "ff7f9156682b6436ea8d0e4ab805b7c0f0d0fd5a",
    "support"
   ],
   "svg/rendering/order/z-index.svg": [
    "786290a158b99a727bf26c4a30556246d30af8dc",
--- a/testing/web-platform/tests/svg/render/reftests/blending-001.svg
+++ b/testing/web-platform/tests/svg/render/reftests/blending-001.svg
@@ -13,31 +13,35 @@
     <html:link rel="match"  href="blending-001-ref.svg" />
   </g>
 
   <style id="test-font" type="text/css">
     rect {
       mix-blend-mode: screen;
     }
 
+    #edgecover > rect {
+      mix-blend-mode: normal;
+    }
+
     g {
       isolation: isolate;
     }
   </style>
 
   <g id="test-body-content">
 
     <g>
       <rect x="120" y="80"  width="160" height="160" fill="red"/>
       <rect x="200" y="80"  width="160" height="160" fill="lime"/>
       <rect x="160" y="160" width="160" height="160" fill="blue"/>
     </g>
 
     <!-- Stroke to prevent aliasing from effecting results. -->
-    <g style="mix-blend-mode:normal;fill:none;stroke:black;stroke-width:2px">
+    <g style="fill:none;stroke:black;stroke-width:2px" id="edgecover">
       <rect x="120" y="80"  width="160" height="160"/>
       <rect x="200" y="80"  width="160" height="160"/>
       <rect x="160" y="160" width="160" height="160"/>
     </g>
 
   </g>
 
 </svg>
--- a/testing/web-platform/tests/svg/render/reftests/blending-002.svg
+++ b/testing/web-platform/tests/svg/render/reftests/blending-002.svg
@@ -13,31 +13,33 @@
     <html:link rel="match"  href="blending-002-ref.svg" />
   </g>
 
   <style id="test-font" type="text/css">
     rect {
       mix-blend-mode: screen;
     }
 
-    g {
-      isolation: isolate;
+    #edgecover > rect {
+      mix-blend-mode: normal;
     }
   </style>
 
   <g id="test-body-content">
 
-    <rect x="120" y="80"  width="160" height="160" fill="red"/>
-    <g>
-      <rect x="200" y="80"  width="160" height="160" fill="lime"/>
-      <rect x="160" y="160" width="160" height="160" fill="blue"/>
+    <g style="isolation: isolate">
+      <rect x="120" y="80"  width="160" height="160" fill="red"/>
+      <g style="isolation: isolate">
+        <rect x="200" y="80"  width="160" height="160" fill="lime"/>
+        <rect x="160" y="160" width="160" height="160" fill="blue"/>
+      </g>
     </g>
 
     <!-- Stroke to prevent aliasing from effecting results. -->
-    <g style="mix-blend-mode:normal;fill:none;stroke:black;stroke-width:2px">
+    <g style="fill:none;stroke:black;stroke-width:2px" id="edgecover">
       <rect x="120" y="80"  width="160" height="160"/>
       <rect x="200" y="80"  width="160" height="160"/>
       <rect x="160" y="160" width="160" height="160"/>
     </g>
 
   </g>
 
 </svg>