Bug 1464939 - Part 1.Remove padding-inline-start and padding-inline-end style from the focusring of devtools's button and tab.r=nchevobbe
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Wed, 13 Jun 2018 17:23:47 -0700
changeset 476933 7f64ce1735056ba178ab0d35a94b63b155dc960a
parent 476932 8141b2848c2c01542cdca4f068ebec284cac2889
child 476934 5e37ebe9339e00dfa93dba4bf07e76a43ec4d243
push id9374
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:43:20 +0000
treeherdermozilla-beta@160e085dfb0b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1464939
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1464939 - Part 1.Remove padding-inline-start and padding-inline-end style from the focusring of devtools's button and tab.r=nchevobbe The devtool's focusring style will set the padding-inline-* to zero[1]. So devtool's button which has padding will shrink the width when target element has the focus. This patch will remove this style. The tab style doesn't have a padding, so this change will not effect the tool tab.[2] Furthermore, this will stretch the height of close button of split console. [1] https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/devtools/client/themes/common.css#270-271 [2] https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/devtools/client/themes/toolbox.css#99 MozReview-Commit-ID: EMgvYEH2Fe1
devtools/client/themes/common.css
devtools/client/themes/webconsole.css
--- a/devtools/client/themes/common.css
+++ b/devtools/client/themes/common.css
@@ -262,18 +262,16 @@ checkbox:-moz-focusring {
   outline: none;
 }
 
 /* Tab and button of toolbox does not need to display outline */
 
 .devtools-button:-moz-focusring,
 .devtools-tab:-moz-focusring {
   outline:none;
-  padding-inline-end: 0;
-  padding-inline-start: 0;
 }
 
 /* Toolbar buttons */
 .devtools-menulist,
 .devtools-toolbarbutton,
 .devtools-button {
   -moz-appearance: none;
   background: transparent;
--- a/devtools/client/themes/webconsole.css
+++ b/devtools/client/themes/webconsole.css
@@ -599,16 +599,18 @@ a.learn-more-link.webconsole-learn-more-
 /* On OSX the cursor turns into a window-resizing cursor at the edges of the
  * window, so bring the end of the close button in. */
 :root[platform="mac"] .split-console-close-button-wrapper {
   padding-inline-end: 3px;
 }
 
 #split-console-close-button {
   margin-inline-end: 0;
+  height: 100%;
+  margin: 0;
 }
 
 .webconsole-filterbar-primary .devtools-plaininput {
   flex: 1 1 100%;
   align-self: stretch;
   margin-left: 1px;
   padding-inline-start: 4px;
   border: 1px solid transparent;