Bug 1520957 - [release 119] changing the position of cursor location and toggle button in the footer (#7684). r=dwalsh
☠☠ backed out by 27034f1841e9 ☠ ☠
authorHet Patel <patel.het33@gmail.com>
Fri, 18 Jan 2019 09:36:41 -0500
changeset 511645 7f05dbce0192f31647bea0c9c10618e983b80331
parent 511644 75ccbec47ddca6296febaa9edc7858c68e1b0892
child 511646 3a73b16bc4e12d5aa462094b2bf0ae2bb48491ad
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdwalsh
bugs1520957
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520957 - [release 119] changing the position of cursor location and toggle button in the footer (#7684). r=dwalsh
devtools/client/debugger/new/dist/debugger.css
devtools/client/debugger/new/src/components/Editor/Footer.css
devtools/client/debugger/new/src/components/Editor/Footer.js
devtools/client/debugger/new/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
--- a/devtools/client/debugger/new/dist/debugger.css
+++ b/devtools/client/debugger/new/dist/debugger.css
@@ -2375,17 +2375,17 @@ menuseparator {
 .source-footer > .commands > .blackboxed > .img.blackBox {
   background: var(--theme-highlight-blue);
 }
 
 .source-footer .blackbox-summary,
 .source-footer .mapped-source,
 .source-footer .cursor-position {
   color: var(--theme-body-color);
-  padding-left: 2.5px;
+  padding-right: 2.5px;
 }
 
 .source-footer .mapped-source {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
 }
 
--- a/devtools/client/debugger/new/src/components/Editor/Footer.css
+++ b/devtools/client/debugger/new/src/components/Editor/Footer.css
@@ -81,17 +81,17 @@
 .source-footer > .commands > .blackboxed > .img.blackBox {
   background: var(--theme-highlight-blue);
 }
 
 .source-footer .blackbox-summary,
 .source-footer .mapped-source,
 .source-footer .cursor-position {
   color: var(--theme-body-color);
-  padding-left: 2.5px;
+  padding-right: 2.5px;
 }
 
 .source-footer .mapped-source {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
 }
 
--- a/devtools/client/debugger/new/src/components/Editor/Footer.js
+++ b/devtools/client/debugger/new/src/components/Editor/Footer.js
@@ -234,18 +234,18 @@ class SourceFooter extends PureComponent
     if (!shouldShowFooter(selectedSource, horizontal)) {
       return null;
     }
 
     return (
       <div className="source-footer">
         {this.renderCommands()}
         {this.renderSourceSummary()}
+        {this.renderCursorPosition()}
         {this.renderToggleButton()}
-        {this.renderCursorPosition()}
       </div>
     );
   }
 }
 
 const mapStateToProps = state => {
   const selectedSource = getSelectedSource(state);
 
--- a/devtools/client/debugger/new/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
+++ b/devtools/client/debugger/new/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
@@ -1,39 +1,39 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`SourceFooter Component default case should render 1`] = `
 <div
   className="source-footer"
 >
+  <span
+    className="cursor-position"
+    title="(Line 2, column 2)"
+  >
+    (2, 2)
+  </span>
   <PaneToggleButton
     collapsed={true}
     horizontal={false}
     key="toggle"
     position="end"
   />
-  <span
-    className="cursor-position"
-    title="(Line 2, column 2)"
-  >
-    (2, 2)
-  </span>
 </div>
 `;
 
 exports[`SourceFooter Component move cursor should render new cursor position 1`] = `
 <div
   className="source-footer"
 >
+  <span
+    className="cursor-position"
+    title="(Line 6, column 11)"
+  >
+    (6, 11)
+  </span>
   <PaneToggleButton
     collapsed={true}
     horizontal={false}
     key="toggle"
     position="end"
   />
-  <span
-    className="cursor-position"
-    title="(Line 6, column 11)"
-  >
-    (6, 11)
-  </span>
 </div>
 `;