Bug 1468517 - Make toolbar_bottom_separator color apply to findbar top border. r=dao
authorTim Nguyen <ntim.bugs@gmail.com>
Sun, 18 Nov 2018 18:16:52 +0000
changeset 503373 7e9cac76980a
parent 503372 b3ceae83e290
child 503374 b42ccd72214c
child 503383 7987651658f0
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1468517
milestone65.0a1
first release with
nightly linux32
7e9cac76980a / 65.0a1 / 20181118220115 / files
nightly linux64
7e9cac76980a / 65.0a1 / 20181118220115 / files
nightly mac
7e9cac76980a / 65.0a1 / 20181118220115 / files
nightly win32
7e9cac76980a / 65.0a1 / 20181118220115 / files
nightly win64
7e9cac76980a / 65.0a1 / 20181118220115 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1468517 - Make toolbar_bottom_separator color apply to findbar top border. r=dao Differential Revision: https://phabricator.services.mozilla.com/D11577
browser/modules/ThemeVariableMap.jsm
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/shared/browser.inc.css
browser/themes/windows/browser.css
--- a/browser/modules/ThemeVariableMap.jsm
+++ b/browser/modules/ThemeVariableMap.jsm
@@ -41,17 +41,17 @@ const ThemeVariableMap = [
   }],
   ["--tabs-border-color", {
     lwtProperty: "toolbar_top_separator",
     optionalElementID: "navigator-toolbox",
   }],
   ["--lwt-toolbar-vertical-separator", {
     lwtProperty: "toolbar_vertical_separator",
   }],
-  ["--toolbox-border-bottom-color", {
+  ["--chrome-content-separator-color", {
     lwtProperty: "toolbar_bottom_separator",
   }],
   ["--lwt-toolbarbutton-icon-fill", {
     lwtProperty: "icon_color",
   }],
   ["--lwt-toolbarbutton-icon-fill-attention", {
     lwtProperty: "icon_attention_color",
   }],
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -19,29 +19,29 @@
 
   --panel-separator-color: ThreeDShadow;
   --arrowpanel-dimmed: hsla(0,0%,80%,.35);
   --arrowpanel-dimmed-further: hsla(0,0%,80%,.5);
   --arrowpanel-dimmed-even-further: hsla(0,0%,80%,.8);
 
   --urlbar-separator-color: ThreeDShadow;
 
-  --toolbox-border-bottom-color: ThreeDShadow;
+  --chrome-content-separator-color: ThreeDShadow;
 }
 
 #navigator-toolbox {
   --tabs-border-color: rgba(0,0,0,.3);
 }
 
 #tabbrowser-tabs {
   --tab-line-color: highlight;
 }
 
 :root:-moz-lwtheme {
-  --toolbox-border-bottom-color: rgba(0,0,0,.3);
+  --chrome-content-separator-color: rgba(0,0,0,.3);
 
   --panel-separator-color: hsla(210,4%,10%,.14);
 }
 
 :root[lwt-popup-brighttext] {
   --panel-separator-color: rgba(249,249,250,.1);
 
   --arrowpanel-dimmed: rgba(249,249,250,.1);
@@ -451,16 +451,17 @@ notification[value="translation"] menuli
 .browserContainer > findbar {
   background-color: var(--toolbar-bgcolor);
   color: var(--toolbar-color);
 }
 
 .browserContainer > findbar:-moz-lwtheme {
   background-color: var(--lwt-accent-color);
   background-image: linear-gradient(var(--toolbar-bgcolor), var(--toolbar-bgcolor));
+  border-top-color: var(--chrome-content-separator-color);
   text-shadow: none;
 }
 
 /* Tabstrip */
 
 %include ../shared/tabs.inc.css
 
 #tabbrowser-tabs {
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -22,21 +22,21 @@
   --arrowpanel-dimmed: hsla(0,0%,80%,.35);
   --arrowpanel-dimmed-further: hsla(0,0%,80%,.5);
   --arrowpanel-dimmed-even-further: hsla(0,0%,80%,.8);
 
   --arrowpanel-field-background: rgba(249,249,250,.3);
 
   --urlbar-separator-color: hsla(0,0%,16%,.2);
 
-  --toolbox-border-bottom-color: #e1e1e2;
+  --chrome-content-separator-color: #e1e1e2;
 }
 
 :root:-moz-lwtheme {
-  --toolbox-border-bottom-color: rgba(0,0,0,.3);
+  --chrome-content-separator-color: rgba(0,0,0,.3);
 }
 
 :root[lwt-popup-brighttext] {
   --panel-separator-color: rgba(249,249,250,.1);
 
   --arrowpanel-dimmed: rgba(249,249,250,.1);
   --arrowpanel-dimmed-further: rgba(249,249,250,.15);
   --arrowpanel-dimmed-even-further: rgba(249,249,250,.2);
@@ -56,17 +56,17 @@
   cancels all backgrounds that are there, so we set it on the toolbox bottom
   border.
 */
 #navigator-toolbox::after {
   -moz-appearance: toolbox;
   height: 1px;
   /* use inset box-shadow instead of border because -moz-appearance hides the border */
   border: none;
-  box-shadow: inset 0 -1px var(--toolbox-border-bottom-color);
+  box-shadow: inset 0 -1px var(--chrome-content-separator-color);
 }
 
 #tabbrowser-tabs {
   --tab-line-color: #0a84ff;
 }
 
 #navigator-toolbox toolbarbutton:-moz-lwtheme {
   color: inherit;
@@ -562,16 +562,17 @@ html|input.urlbar-input {
   border-top: @scopeBarSeparatorBorder@;
   color: -moz-DialogText;
   text-shadow: none;
 }
 
 .browserContainer > findbar:-moz-lwtheme {
   background-color: var(--lwt-accent-color);
   background-image: linear-gradient(var(--toolbar-bgcolor), var(--toolbar-bgcolor));
+  border-top-color: var(--chrome-content-separator-color);
   color: var(--toolbar-color);
 }
 
 .openintabs-menuitem {
   list-style-image: none;
 }
 
 /* ::::: tabbrowser ::::: */
--- a/browser/themes/shared/browser.inc.css
+++ b/browser/themes/shared/browser.inc.css
@@ -25,17 +25,17 @@
   color: @lwtPopupBrighttextLinkColor@;
 }
 
 /* Toolbar / content area border */
 
 #navigator-toolbox::after {
   content: "";
   display: -moz-box;
-  border-bottom: 1px solid var(--toolbox-border-bottom-color);
+  border-bottom: 1px solid var(--chrome-content-separator-color);
 }
 
 :root[customizing] #navigator-toolbox::after {
   border-bottom-style: none;
 }
 
 :root[sessionrestored] #nav-bar:-moz-lwtheme {
   transition: @themeTransition@;
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -19,17 +19,17 @@
 
   --panel-separator-color: ThreeDLightShadow;
   --arrowpanel-dimmed: hsla(0,0%,80%,.35);
   --arrowpanel-dimmed-further: hsla(0,0%,80%,.5);
   --arrowpanel-dimmed-even-further: hsla(0,0%,80%,.8);
 
   --urlbar-separator-color: ThreeDLightShadow;
 
-  --toolbox-border-bottom-color: ThreeDShadow;
+  --chrome-content-separator-color: ThreeDShadow;
 }
 
 #navigator-toolbox {
   --tabs-border-color: threedshadow;
 }
 
 #tabbrowser-tabs {
   --tab-line-color: highlight;
@@ -40,30 +40,30 @@
     --toolbar-non-lwt-bgcolor: #f9f9fa;
     --toolbar-non-lwt-textcolor: #0c0c0d;
     --toolbar-non-lwt-bgimage: none;
 
     --toolbarbutton-icon-fill-opacity: .7;
 
     --panel-separator-color: hsla(210,4%,10%,.14);
 
-    --toolbox-border-bottom-color: #e1e1e2;
+    --chrome-content-separator-color: #e1e1e2;
   }
 
   #navigator-toolbox {
     --tabs-border-color: rgba(0,0,0,.3);
   }
 
   #tabbrowser-tabs {
     --tab-line-color: #0a84ff;
   }
 }
 
 :root:-moz-lwtheme {
-  --toolbox-border-bottom-color: rgba(0,0,0,.3);
+  --chrome-content-separator-color: rgba(0,0,0,.3);
 
   --panel-separator-color: hsla(210,4%,10%,.14);
 }
 
 :root[lwt-popup-brighttext] {
   --panel-separator-color: rgba(249,249,250,.1);
 
   --arrowpanel-dimmed: rgba(249,249,250,.1);
@@ -667,16 +667,17 @@ html|*.urlbar-input:-moz-lwtheme::placeh
 .browserContainer > findbar {
   background-color: var(--toolbar-bgcolor);
   color: var(--toolbar-color);
 }
 
 .browserContainer > findbar:-moz-lwtheme {
   background-color: var(--lwt-accent-color);
   background-image: linear-gradient(var(--toolbar-bgcolor), var(--toolbar-bgcolor));
+  border-top-color: var(--chrome-content-separator-color);
   text-shadow: none;
 }
 
 /* Tabstrip */
 
 #TabsToolbar {
   min-height: 0;
   padding: 0;