Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj
☠☠ backed out by cd74e3f9f61e ☠ ☠
authorMiko Mynttinen <mikokm@gmail.com>
Fri, 01 Jun 2018 14:09:30 +0200
changeset 475325 7c8905b6b2264e7c20e6ab3f3def7d818c007f5b
parent 475324 10446073eca89bc3099523a5f3795ea7aa45cf2f
child 475326 cd74e3f9f61e1e48f872f1b365400668256c28aa
push id9374
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:43:20 +0000
treeherdermozilla-beta@160e085dfb0b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1465060
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj MozReview-Commit-ID: KtQ31q6uFqZ
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -81,22 +81,16 @@ check_and_add_gcc_warning('-Wstring-conv
 
 # we inline 'new' and 'delete' in mozalloc
 check_and_add_gcc_warning('-Wno-inline-new-delete', cxx_compiler)
 
 # Prevent the following GCC warnings from being treated as errors:
 # too many false positives
 check_and_add_gcc_warning('-Wno-error=maybe-uninitialized')
 
-# Turned on by -Wall, but needs changes to be turned into an error
-# (bug 1465060).
-check_and_add_gcc_warning('-Wno-error=pessimizing-move')
-# This one is probably easier, it's only triggered by tests.
-check_and_add_gcc_warning('-Wno-error=self-move')
-
 # we don't want our builds held hostage when a platform-specific API
 # becomes deprecated.
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')
 
 # false positives depending on optimization
 check_and_add_gcc_warning('-Wno-error=array-bounds')
 
 # can't get rid of those PGO warnings