Bug 900097 - statusbarpanel shouldn't be a button accessible. r=enn, a=lsblakk
authorMax Li <maxli@maxli.ca>
Thu, 08 Aug 2013 18:39:56 -0400
changeset 153714 7c668796e2d249d6a52893157c7cfbf656547a36
parent 153713 7c8d69378d3a034aa733c4f5bfa631749f71da55
child 153715 6968e01da75f32aa5e824105e4de1bc02cfb2927
push id2859
push userakeybl@mozilla.com
push dateMon, 16 Sep 2013 19:14:59 +0000
treeherdermozilla-beta@87d3c51cd2bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersenn, lsblakk
bugs900097
milestone25.0a2
Bug 900097 - statusbarpanel shouldn't be a button accessible. r=enn, a=lsblakk
toolkit/content/widgets/general.xml
--- a/toolkit/content/widgets/general.xml
+++ b/toolkit/content/widgets/general.xml
@@ -108,25 +108,17 @@
 
   <binding id="statusbarpanel" display="xul:button">
     <content>
       <children>
         <xul:label class="statusbarpanel-text" xbl:inherits="value=label,crop" crop="right" flex="1"/>
       </children>
     </content>
 
-    <implementation implements="nsIAccessibleProvider">
-      <property name="accessibleType" readonly="true">
-        <getter>
-          <![CDATA[
-            return Components.interfaces.nsIAccessibleProvider.XULButton;
-          ]]>
-        </getter>
-      </property>
-
+    <implementation>
       <property name="label"
                 onget="return this.getAttribute('label');"
                 onset="this.setAttribute('label',val); return val;"/>
       <property name="image"
                 onget="return this.getAttribute('image');"
                 onset="this.setAttribute('image',val); return val;"/>
       <property name="src"
                 onget="return this.getAttribute('src');"
@@ -179,24 +171,44 @@
     </implementation>
   </binding>
 
   <binding id="statusbarpanel-iconic" display="xul:button"
            extends="chrome://global/content/bindings/general.xml#statusbarpanel">
     <content>
       <xul:image class="statusbarpanel-icon" xbl:inherits="src,src=image"/>
     </content>
+
+    <implementation implements="nsIAccessibleProvider">
+      <property name="accessibleType" readonly="true">
+        <getter>
+          <![CDATA[
+            return Components.interfaces.nsIAccessibleProvider.XULButton;
+          ]]>
+        </getter>
+      </property>
+    </implementation>
   </binding>
 
   <binding id="statusbarpanel-iconic-text" display="xul:button"
            extends="chrome://global/content/bindings/general.xml#statusbarpanel">
     <content>
       <xul:image class="statusbarpanel-icon" xbl:inherits="src,src=image"/>
       <xul:label class="statusbarpanel-text" xbl:inherits="value=label,crop"/>
     </content>
+
+    <implementation implements="nsIAccessibleProvider">
+      <property name="accessibleType" readonly="true">
+        <getter>
+          <![CDATA[
+            return Components.interfaces.nsIAccessibleProvider.XULButton;
+          ]]>
+        </getter>
+      </property>
+    </implementation>
   </binding>
 
   <binding id="image">
     <implementation implements="nsIDOMXULImageElement, nsIAccessibleProvider">
       <property name="src"
                 onget="return this.getAttribute('src');"
                 onset="this.setAttribute('src',val); return val;"/>
       <property name="accessibleType" readonly="true">