Backed out changeset 1e6febc9f5af (bug 1436778) for being too easy to hit, by just running navigation-timing/test_performance_attributes_exist_in_object.html
authorPhil Ringnalda <philringnalda@gmail.com>
Fri, 13 Apr 2018 19:03:36 -0700
changeset 466843 7c3b8b5a6ac8f4c15631cf80726be8b72d161bf7
parent 466842 c19f2cea4987db5855c65b7128f10643a4eef99b
child 466844 26bee50f8c274bdc0a38b5a77f9991f5159bc399
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1436778
milestone61.0a1
backs out1e6febc9f5af217779860536398cd1c60122e2e1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 1e6febc9f5af (bug 1436778) for being too easy to hit, by just running navigation-timing/test_performance_attributes_exist_in_object.html
dom/performance/PerformanceTiming.cpp
--- a/dom/performance/PerformanceTiming.cpp
+++ b/dom/performance/PerformanceTiming.cpp
@@ -81,25 +81,16 @@ PerformanceTiming::PerformanceTiming(Per
   MOZ_ASSERT(aPerformance, "Parent performance object should be provided");
 
   mTimingData.reset(new PerformanceTimingData(aChannel, aHttpChannel,
     aPerformance->IsSystemPrincipal()
     ? aZeroTime
     : nsRFPService::ReduceTimePrecisionAsMSecs(aZeroTime,
         aPerformance->GetRandomTimelineSeed())));
 
-#ifdef DEBUG
-  if (mTimingData->ResponseStartHighRes(aPerformance) - mTimingData->ZeroTime() < 0) {
-    MOZ_CRASH_UNSAFE_PRINTF("Heisenbug Reproduced: Please file line in 1436778. %s %f - %f (%f)",
-      (aPerformance->IsSystemPrincipal() ? "System" : "Not-System"),
-      mTimingData->ResponseStartHighRes(aPerformance),
-      mTimingData->ZeroTime(), aZeroTime);
-  }
-#endif
-
   // Non-null aHttpChannel implies that this PerformanceTiming object is being
   // used for subresources, which is irrelevant to this probe.
   if (!aHttpChannel &&
       nsContentUtils::IsPerformanceTimingEnabled() &&
       IsTopLevelContentDocument()) {
     Telemetry::Accumulate(Telemetry::TIME_TO_RESPONSE_START_MS,
                           mTimingData->ResponseStartHighRes(aPerformance) -
                             mTimingData->ZeroTime());