Bug 1584612 [wpt PR 19377] - Reland "[ChromeDriver] Stop using --ignore-certificate-errors", a=testonly
authorJohn Chen <johnchen@chromium.org>
Mon, 14 Oct 2019 13:41:22 +0000
changeset 559576 7c0ec840ec758328aca379b2f14d43b022109be8
parent 559575 1de6caa2ec6e26a346752578c1ecc2966f195972
child 559577 92de08c4fecf6e0f06c1fa5f99a68aa8892b3c95
push id12177
push usercsabou@mozilla.com
push dateMon, 21 Oct 2019 14:52:16 +0000
treeherdermozilla-beta@1918a9cd33bc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1584612, 19377, 1824005, 699890, 1829802, 701614
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1584612 [wpt PR 19377] - Reland "[ChromeDriver] Stop using --ignore-certificate-errors", a=testonly Automatic update from web-platform-tests Reland "[ChromeDriver] Stop using --ignore-certificate-errors" This is a reland of 8f486945b4c91f67b76e02bfd8c39b0a9cf08089 Original change's description: > [ChromeDriver] Stop using --ignore-certificate-errors > > ChromeDriver was passing --ignore-certificate-errors switch to Chrome, > regardless of whether user wants to ignore certificate errors or not. > Fixing by stop passing this flag to Chrome, and relying on using > Security.setIgnoreCertificateErrors command when user wants to ignore > certificate errors. > > Bug: chromedriver:3148 > Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699890} Bug: chromedriver:3148 Change-Id: I96ce5e6746af65e01407e7c6c92fed7428d686ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829802 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701614} -- wpt-commits: cfa91b8cdf20d0d2ff4531b16d0800cc2ed2a598 wpt-pr: 19377
testing/web-platform/tests/webdriver/tests/permissions/set.py
--- a/testing/web-platform/tests/webdriver/tests/permissions/set.py
+++ b/testing/web-platform/tests/webdriver/tests/permissions/set.py
@@ -25,16 +25,17 @@ def query(session, name):
     { "descriptor": { }, "state": "granted" },
     { "descriptor": { "name": "geolocation" }, "state": "Granted" },
     { "descriptor": 23, "state": "granted" },
     { "descriptor": "geolocation", "state": "granted" },
     { "descriptor": [ { "name": "geolocation" } ], "state": "granted" },
     [ { "descriptor": { "name": "geolocation" }, "state": "granted" } ],
     { "descriptor": { "name": "geolocation" }, "state": "granted", "oneRealm": 23 }
 ])
+@pytest.mark.capabilities({"acceptInsecureCerts": True})
 def test_invalid_parameters(session, url, parameters):
     session.url = url("/common/blank.html", protocol="https")
     response = session.transport.send(
         "POST",
         "/session/{session_id}/permissions".format(**vars(session)),
         parameters
     )
     assert_error(response, "invalid argument")
@@ -53,16 +54,17 @@ def test_non_secure_context(session, url
     assert_error(response, "invalid argument")
 
 @pytest.mark.parametrize("state", ["granted", "denied", "prompt"])
 @pytest.mark.parametrize("realmSetting", [
     { "oneRealm": True },
     { "oneRealm": False },
     {}
 ])
+@pytest.mark.capabilities({"acceptInsecureCerts": True})
 def test_set_to_state(session, url, state, realmSetting):
     session.url = url("/common/blank.html", protocol="https")
     parameters = { "descriptor": { "name": "geolocation" }, "state": state }
     parameters.update(realmSetting)
     response = session.transport.send(
         "POST", "/session/{session_id}/permissions".format(**vars(session)),
         parameters
     )
@@ -92,16 +94,17 @@ def test_set_to_state(session, url, stat
 # >    objects whose origin is the same as the origin of settings.
 #
 # Ensure that all realms are affected when `oneRealm` is not enabled.
 @pytest.mark.parametrize("state", ["granted", "denied", "prompt"])
 @pytest.mark.parametrize("realmSetting", [
     { "oneRealm": False },
     {}
 ])
+@pytest.mark.capabilities({"acceptInsecureCerts": True})
 def test_set_to_state_cross_realm(session, create_window, url, state, realmSetting):
     session.url = url("/common/blank.html", protocol="https")
     original_window = session.window_handle
     session.window_handle = create_window()
     session.url = url("/common/blank.html", protocol="https")
     parameters = { "descriptor": { "name": "geolocation" }, "state": state }
     parameters.update(realmSetting)