Bug 1499944 - Don't show detail view when changing plugin state r=jaws
authorMark Striemer <mstriemer@mozilla.com>
Thu, 18 Oct 2018 18:43:03 +0000
changeset 497737 7b0a8e47d25608312af369290db040fa9009ddcf
parent 497736 9a404545425a2d59f36f3acadc99f1a55c366429
child 497738 272fbc5589a88513c9e9212d94bc6792731bc434
child 497748 c0c288dc283e315982949e5d6565520f5872ab12
push id10002
push userarchaeopteryx@coole-files.de
push dateFri, 19 Oct 2018 23:09:29 +0000
treeherdermozilla-beta@01378c910610 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1499944
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1499944 - Don't show detail view when changing plugin state r=jaws Differential Revision: https://phabricator.services.mozilla.com/D9061
toolkit/mozapps/extensions/content/extensions.xml
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -1486,17 +1486,17 @@
         <body><![CDATA[
             this._updateState();
         ]]></body>
       </method>
     </implementation>
 
     <handlers>
       <handler event="click" button="0"><![CDATA[
-        if (!["button", "checkbox"].includes(event.originalTarget.localName) &&
+        if (!["button", "checkbox", "menulist", "menuitem"].includes(event.originalTarget.localName) &&
             !event.originalTarget.classList.contains("text-link")) {
           this.showInDetailView();
         }
       ]]></handler>
     </handlers>
   </binding>