Bug 1444760 - Followup: Fix params is null exception. r=me
☠☠ backed out by 384c57a10906 ☠ ☠
authorTim Nguyen <ntim.bugs@gmail.com>
Sat, 17 Mar 2018 15:40:39 +0000
changeset 462240 79b40369822f20507569bacefd6a4ee6b8f29871
parent 462239 6ec4bc1d3720b22da681ba83b352b056909fb5a1
child 462241 00da6f45a098a51748cce5759fb3ed6241d6afa9
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1444760
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1444760 - Followup: Fix params is null exception. r=me
browser/base/content/browser.js
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -1016,34 +1016,34 @@ function handleUriInChrome(aBrowser, aUr
     }
   }
 
   return false;
 }
 
 // A shared function used by both remote and non-remote browser XBL bindings to
 // load a URI or redirect it to the correct process.
-function _loadURI(browser, uri, params = {}) {
+function _loadURI(browser, uri, params) {
   let tab = gBrowser.getTabForBrowser(browser);
   // Preloaded browsers don't have tabs, so we ignore those.
   if (tab) {
     maybeRecordAbandonmentTelemetry(tab, "newURI");
   }
 
   if (!uri) {
     uri = "about:blank";
   }
 
   let {
     flags = Ci.nsIWebNavigation.LOAD_FLAGS_NONE,
     referrerURI,
     referrerPolicy = Ci.nsIHttpChannel.REFERRER_POLICY_UNSET,
     triggeringPrincipal,
     postData,
-  } = params;
+  } = params || {};
 
   let currentRemoteType = browser.remoteType;
   let requiredRemoteType;
   try {
     let fixupFlags = Ci.nsIURIFixup.FIXUP_FLAG_NONE;
     if (flags & Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP) {
       fixupFlags |= Ci.nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP;
     }