Bug 1526435 - Don't use DisableCompilerWarnings in libdav1d builds. r=dmajor
authorAlex Chronopoulos <achronop@gmail.com>
Thu, 14 Mar 2019 15:18:12 +0000
changeset 521887 791bf490c9ca772917317638a7f8241447e84ec0
parent 521886 0ec93de240d9f09065ea7694c8148cdb36477a64
child 521888 13f5ef3dcbb66700014ee970d3dbfb784e1ce606
push id10870
push usernbeleuzu@mozilla.com
push dateFri, 15 Mar 2019 20:00:07 +0000
treeherdermozilla-beta@c594aee5b7a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1526435
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1526435 - Don't use DisableCompilerWarnings in libdav1d builds. r=dmajor Differential Revision: https://phabricator.services.mozilla.com/D23505
media/libdav1d/asm/moz.build
media/libdav1d/moz.build
--- a/media/libdav1d/asm/moz.build
+++ b/media/libdav1d/asm/moz.build
@@ -176,9 +176,10 @@ elif CONFIG['CPU_ARCH'] == 'arm' or CONF
         SOURCES += ['../../../third_party/dav1d/src/arm/64/mc.S']
     elif CONFIG['CPU_ARCH'] == 'arm':
         SOURCES += ['../../../third_party/dav1d/src/arm/32/mc.S']
 
 USE_NASM = True
 
 FINAL_LIBRARY = 'gkmedias'
 
-DisableCompilerWarnings()
+# We allow warnings for third-party code that can be updated from upstream.
+AllowCompilerWarnings()
--- a/media/libdav1d/moz.build
+++ b/media/libdav1d/moz.build
@@ -181,11 +181,8 @@ if CONFIG['OS_TARGET'] == 'WINNT':
 if CONFIG['CC_TYPE'] == 'gcc':
     LOCAL_INCLUDES += ['../../third_party/dav1d/include/compat/gcc/']
     EXPORTS.dav1d += ['../../third_party/dav1d/include/compat/gcc/stdatomic.h']
 
 FINAL_LIBRARY = 'gkmedias'
 
 # We allow warnings for third-party code that can be updated from upstream.
 AllowCompilerWarnings()
-
-# And furthermore, don't show warnings.
-DisableCompilerWarnings()