Bug 892911 - Check that media section is found before adding rtcp-fb attributes r=ekr a=bbajaj
authorAdam Roach [:abr] <adam@nostrum.com>
Fri, 12 Jul 2013 05:49:12 -0500
changeset 147940 777c69b17263a93e3196d716e409285c6cb4a973
parent 147939 857e92069571d9c5ed4a22d1c3b96f7bda0b35dd
child 147941 cf83a645ad5859f320c022fc81e2bdfadff31835
push id2697
push userbbajaj@mozilla.com
push dateMon, 05 Aug 2013 18:49:53 +0000
treeherdermozilla-beta@dfec938c7b63 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersekr, bbajaj
bugs892911
milestone24.0a2
Bug 892911 - Check that media section is found before adding rtcp-fb attributes r=ekr a=bbajaj
media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
--- a/media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
+++ b/media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
@@ -4805,17 +4805,17 @@ gsmsdp_negotiate_media_lines (fsm_fcb_t 
             unsupported_line = TRUE;
             break;
         }
 
         /* TODO (abr) -- temporarily hardcode rtcb-fb attributes to match our
            actual behavior. This really needs to be a negotiation, with the
            results of the negotiation propagating into the codec configuration.
            See Bug 880067. */
-        if (media_type == SDP_MEDIA_VIDEO) {
+        if (media && media_type == SDP_MEDIA_VIDEO) {
             gsmsdp_set_rtcp_fb_nack_attribute(media->level, sdp_p->src_sdp,
                                               SDP_ALL_PAYLOADS,
                                               SDP_RTCP_FB_NACK_UNSPECIFIED);
             gsmsdp_set_rtcp_fb_ccm_attribute(media->level, sdp_p->src_sdp,
                                              SDP_ALL_PAYLOADS,
                                              SDP_RTCP_FB_CCM_FIR);
         }