Bug 1437125 - Remove operand read of JSOP_DEFFUN from inspectOpcode. r=tcampbell
authorNicolas B. Pierron <nicolas.b.pierron@gmail.com>
Fri, 09 Feb 2018 17:49:06 +0000
changeset 455915 772a11f3103b621c19717a024f8edbda5de3f267
parent 455914 d12cc905dbcdd92e7bb60f2d492441c8c91ca1bd
child 455916 226ade1626def4a37f969fffa201f9a2c6fa6dc2
push id8799
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 16:46:23 +0000
treeherdermozilla-beta@15334014dc67 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstcampbell
bugs1437125
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1437125 - Remove operand read of JSOP_DEFFUN from inspectOpcode. r=tcampbell
js/src/jit/IonBuilder.cpp
js/src/jit/IonBuilder.h
--- a/js/src/jit/IonBuilder.cpp
+++ b/js/src/jit/IonBuilder.cpp
@@ -1850,17 +1850,17 @@ IonBuilder::inspectOpcode(JSOp op)
       case JSOP_DEFVAR:
         return jsop_defvar(GET_UINT32_INDEX(pc));
 
       case JSOP_DEFLET:
       case JSOP_DEFCONST:
         return jsop_deflexical(GET_UINT32_INDEX(pc));
 
       case JSOP_DEFFUN:
-        return jsop_deffun(GET_UINT32_INDEX(pc));
+        return jsop_deffun();
 
       case JSOP_EQ:
       case JSOP_NE:
       case JSOP_STRICTEQ:
       case JSOP_STRICTNE:
       case JSOP_LT:
       case JSOP_LE:
       case JSOP_GT:
@@ -12442,17 +12442,17 @@ IonBuilder::jsop_deflexical(uint32_t ind
 
     MDefLexical* deflex = MDefLexical::New(alloc(), name, attrs);
     current->add(deflex);
 
     return resumeAfter(deflex);
 }
 
 AbortReasonOr<Ok>
-IonBuilder::jsop_deffun(uint32_t index)
+IonBuilder::jsop_deffun()
 {
     MOZ_ASSERT(usesEnvironmentChain());
 
     MDefFun* deffun = MDefFun::New(alloc(), current->pop(), current->environmentChain());
     current->add(deffun);
 
     return resumeAfter(deffun);
 }
--- a/js/src/jit/IonBuilder.h
+++ b/js/src/jit/IonBuilder.h
@@ -499,17 +499,17 @@ class IonBuilder
     AbortReasonOr<Ok> jsop_binary_arith(JSOp op, MDefinition* left, MDefinition* right);
     AbortReasonOr<Ok> jsop_pow();
     AbortReasonOr<Ok> jsop_pos();
     AbortReasonOr<Ok> jsop_neg();
     AbortReasonOr<Ok> jsop_tostring();
     AbortReasonOr<Ok> jsop_setarg(uint32_t arg);
     AbortReasonOr<Ok> jsop_defvar(uint32_t index);
     AbortReasonOr<Ok> jsop_deflexical(uint32_t index);
-    AbortReasonOr<Ok> jsop_deffun(uint32_t index);
+    AbortReasonOr<Ok> jsop_deffun();
     AbortReasonOr<Ok> jsop_notearg();
     AbortReasonOr<Ok> jsop_throwsetconst();
     AbortReasonOr<Ok> jsop_checklexical();
     AbortReasonOr<Ok> jsop_checkaliasedlexical(EnvironmentCoordinate ec);
     AbortReasonOr<Ok> jsop_funcall(uint32_t argc);
     AbortReasonOr<Ok> jsop_funapply(uint32_t argc);
     AbortReasonOr<Ok> jsop_funapplyarguments(uint32_t argc);
     AbortReasonOr<Ok> jsop_funapplyarray(uint32_t argc);