Bug 1378092 - Consider to remove MaybeGC from AutoEntryScript::~AutoEntryScript(), r=jonco
authorOlli Pettay <Olli.Pettay@helsinki.fi>
Thu, 07 Sep 2017 09:28:25 +0100
changeset 429012 76f8a8ccd62644c48faf171d906c03edef8284ae
parent 429011 66023b60b9aaa6f3e15fda2e644727ae2f3ab3fe
child 429013 20ca9381933394f96a736f5fd214b3c3b3efbdcb
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjonco
bugs1378092
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1378092 - Consider to remove MaybeGC from AutoEntryScript::~AutoEntryScript(), r=jonco
dom/script/ScriptSettings.cpp
--- a/dom/script/ScriptSettings.cpp
+++ b/dom/script/ScriptSettings.cpp
@@ -684,20 +684,16 @@ AutoEntryScript::AutoEntryScript(JSObjec
                                  const char* aReason,
                                  bool aIsMainThread)
   : AutoEntryScript(xpc::NativeGlobal(aObject), aReason, aIsMainThread)
 {
 }
 
 AutoEntryScript::~AutoEntryScript()
 {
-  // GC when we pop a script entry point. This is a useful heuristic that helps
-  // us out on certain (flawed) benchmarks like sunspider, because it lets us
-  // avoid GCing during the timing loop.
-  JS_MaybeGC(cx());
 }
 
 AutoEntryScript::DocshellEntryMonitor::DocshellEntryMonitor(JSContext* aCx,
                                                             const char* aReason)
   : JS::dbg::AutoEntryMonitor(aCx)
   , mReason(aReason)
 {
 }