Bug 1307212 - Stop warning about z-levels. r=froydnj
authorEric Rahm <erahm@mozilla.com>
Tue, 23 May 2017 15:14:07 -0700
changeset 408448 76e550bb72f7ec284b336f71c5f9674023c6e551
parent 408447 c8c27d022b8756aa17c19e4a28db89f66412f497
child 408449 fac6b111e23b34d227f1862ba3188a578b709756
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1307212
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1307212 - Stop warning about z-levels. r=froydnj MozReview-Commit-ID: 2OughbymcrU
xpfe/appshell/nsWindowMediator.cpp
--- a/xpfe/appshell/nsWindowMediator.cpp
+++ b/xpfe/appshell/nsWindowMediator.cpp
@@ -608,22 +608,20 @@ nsWindowMediator::SetZPosition(
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsWindowMediator::GetZLevel(nsIXULWindow *aWindow, uint32_t *_retval)
 {
   NS_ENSURE_ARG_POINTER(_retval);
   *_retval = nsIXULWindow::normalZ;
+  // This can fail during window destruction.
   nsWindowInfo *info = GetInfoFor(aWindow);
   if (info) {
     *_retval = info->mZLevel;
-  } else {
-    NS_WARNING("getting z level of unregistered window");
-    // this goes off during window destruction
   }
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsWindowMediator::SetZLevel(nsIXULWindow *aWindow, uint32_t aZLevel)
 {
   MOZ_RELEASE_ASSERT(NS_IsMainThread());