Backed out changeset 4c5d2dbc051c (bug 1252075) for hazard failures
authorWes Kocher <wkocher@mozilla.com>
Mon, 29 Feb 2016 15:56:09 -0800
changeset 322522 76ded94f97a300223053e43fb0790c97349a42d9
parent 322521 aae846e4552bb3800bfc19011b839b8539b44008
child 322523 d0d2cd5f762bd3cc932d3d86ed6d4b1c465929b8
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1252075
milestone47.0a1
backs out4c5d2dbc051c9d6d8ddcda2a66115fcecffa1d25
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 4c5d2dbc051c (bug 1252075) for hazard failures MozReview-Commit-ID: 4teKKva9Ydw *** Backed out changeset 65a12991543f (bug 1252075) for hazard failures MozReview-Commit-ID: GqMt4nsU3oQ
js/src/jsapi-tests/testGCHeapPostBarriers.cpp
--- a/js/src/jsapi-tests/testGCHeapPostBarriers.cpp
+++ b/js/src/jsapi-tests/testGCHeapPostBarriers.cpp
@@ -3,16 +3,18 @@
 */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "js/RootingAPI.h"
 #include "jsapi-tests/tests.h"
 
+using mozilla::ScopedDeletePtr;
+
 BEGIN_TEST(testGCHeapPostBarriers)
 {
 #ifdef JS_GC_ZEAL
     AutoLeaveZeal nozeal(cx);
 #endif /* JS_GC_ZEAL */
 
     /* Sanity check - objects start in the nursery and then become tenured. */
     JS_GC(cx->runtime());
@@ -39,17 +41,17 @@ Passthrough(bool value)
 template <typename T>
 bool
 TestHeapPostBarriers(T initialObj)
 {
     CHECK(initialObj != nullptr);
     CHECK(js::gc::IsInsideNursery(initialObj));
 
     /* Construct Heap<> wrapper. */
-    auto heapData = mozilla::MakeUnique<JS::Heap<T>>();
+    ScopedDeletePtr<JS::Heap<T>> heapData(new JS::Heap<T>);
     CHECK(heapData.get());
     CHECK(Passthrough(heapData->get() == nullptr));
     *heapData = initialObj;
 
     /* Store the pointer as an integer so that the hazard analysis will miss it. */
     uintptr_t initialObjAsInt = uintptr_t(initialObj);
 
     /* Perform minor GC and check heap wrapper is udated with new pointer. */