Bug 1275432 - showing container icons in file and tab menu. r=jaws
authorJonathan Kingston <jkingston@mozilla.com>
Thu, 26 May 2016 12:12:24 +0100
changeset 339583 76b6cebf4b36eb64120c91ba0f536e6fd845bafe
parent 339582 57bdeb9f1eca2a87dba18150e93129dcc1f8d4e9
child 339584 0a3b6e2df6567d845f31c000c68dd67816c6153d
child 340682 5633471e8622637ee620f06bab13d831a764d1fb
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1275432
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1275432 - showing container icons in file and tab menu. r=jaws MozReview-Commit-ID: 9QJHU188MwI
browser/base/content/utilityOverlay.js
browser/themes/linux/browser.css
--- a/browser/base/content/utilityOverlay.js
+++ b/browser/base/content/utilityOverlay.js
@@ -417,22 +417,23 @@ function createUserContextMenu(event, ad
   let bundle = document.getElementById("bundle_browser");
   let docfrag = document.createDocumentFragment();
 
   ContextualIdentityService.getIdentities().forEach(identity => {
     let menuitem = document.createElement("menuitem");
     menuitem.setAttribute("usercontextid", identity.userContextId);
     menuitem.setAttribute("label", bundle.getString(identity.label));
     menuitem.setAttribute("accesskey", bundle.getString(identity.accessKey));
+    menuitem.classList.add("menuitem-iconic");
 
     if (addCommandAttribute) {
       menuitem.setAttribute("command", "Browser:NewUserContextTab");
     }
 
-    menuitem.style.listStyleImage = "url(" + identity.icon + ")";
+    menuitem.setAttribute("image", identity.icon);
 
     docfrag.appendChild(menuitem);
   });
 
   event.target.appendChild(docfrag);
   return true;
 }
 
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -1982,8 +1982,12 @@ notification.pluginVulnerable > .notific
   padding-inline-end: 0 !important;
   margin-inline-end: 0 !important;
 }
 
 .browser-extension-panel > .panel-arrowcontainer > .panel-arrowcontent {
   padding: 0;
   overflow: hidden;
 }
+
+.menuitem-iconic[command="Browser:NewUserContextTab"] > .menu-iconic-left > .menu-iconic-icon {
+  visibility: visible;
+}